You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/25 22:46:28 UTC

[GitHub] [superset] AAfghahi opened a new pull request #13349: refactor: Share sql lab query

AAfghahi opened a new pull request #13349:
URL: https://github.com/apache/superset/pull/13349


   ### SUMMARY
   Changed the share SQL Lab Query button into a TypeScript file using react hooks. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   When Query is not saved:
   ![Screen Shot 2021-02-25 at 5 45 38 PM](https://user-images.githubusercontent.com/48933336/109229471-567e1980-7791-11eb-8b36-88d78134c26e.png)
   When Query is saved: 
   ![Screen Shot 2021-02-25 at 5 45 49 PM](https://user-images.githubusercontent.com/48933336/109229478-5aaa3700-7791-11eb-93d0-6734a10ab831.png)
   
   
   ### TEST PLAN
   re-wrote the tests in react testing library, need some help with the last one. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on a change in pull request #13349: refactor: Share sql lab query

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13349:
URL: https://github.com/apache/superset/pull/13349#discussion_r584026448



##########
File path: superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx
##########
@@ -30,17 +29,17 @@ import { storeQuery } from 'src/utils/common';
 import { getClientErrorObject } from 'src/utils/getClientErrorObject';
 import { FeatureFlag, isFeatureEnabled } from '../../featureFlags';
 
-const propTypes = {
-  queryEditor: PropTypes.shape({
-    dbId: PropTypes.number,
-    title: PropTypes.string,
-    schema: PropTypes.string,
-    autorun: PropTypes.bool,
-    sql: PropTypes.string,
-    remoteId: PropTypes.number,
-  }).isRequired,
-  addDangerToast: PropTypes.func.isRequired,
-};
+interface propTypes {
+  queryEditor: {
+    dbId: number;
+    title: string;
+    schema: string;
+    autorun: boolean;
+    sql: string;
+    remoteId: number;

Review comment:
       looks like this is the only one that is required.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on a change in pull request #13349: refactor: Share sql lab query

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13349:
URL: https://github.com/apache/superset/pull/13349#discussion_r584026598



##########
File path: superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx
##########
@@ -74,28 +66,34 @@ class ShareSqlLabQuery extends React.Component {
       })
       .catch(response => {
         getClientErrorObject(response).then(() => {
-          this.props.addDangerToast(t('There was an error with your request'));
+          addDangerToast(t('There was an error with your request'));
         });
       });
-  }
+  };
 
-  getCopyUrlForSavedQuery(callback) {
+  const getCopyUrlForSavedQuery = (callback: any) => {
     let savedQueryToastContent;
 
-    if (this.props.queryEditor.remoteId) {
+    if (queryEditor.remoteId) {
       savedQueryToastContent = `${
         window.location.origin + window.location.pathname
-      }?savedQueryId=${this.props.queryEditor.remoteId}`;
+      }?savedQueryId=${queryEditor.remoteId}`;
       callback(savedQueryToastContent);
     } else {
       savedQueryToastContent = t('Please save the query to enable sharing');
       callback(savedQueryToastContent);
     }
-  }
+  };
+  const getCopyUrl = (callback: any) => {

Review comment:
       the three callbacks can have a function type instead of any




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13349: refactor: Share sql lab query

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13349:
URL: https://github.com/apache/superset/pull/13349#issuecomment-786319321


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=h1) Report
   > Merging [#13349](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=desc) (4de6040) into [master](https://codecov.io/gh/apache/superset/commit/e11d0cbf44e9bd1115ae01676c1d9a5d51d56990?el=desc) (e11d0cb) will **decrease** coverage by `0.08%`.
   > The diff coverage is `53.15%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13349/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13349      +/-   ##
   ==========================================
   - Coverage   76.87%   76.79%   -0.09%     
   ==========================================
     Files         880      912      +32     
     Lines       45491    46448     +957     
     Branches     5380     5645     +265     
   ==========================================
   + Hits        34973    35668     +695     
   - Misses      10395    10640     +245     
   - Partials      123      140      +17     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `60.48% <38.24%> (+2.41%)` | :arrow_up: |
   | hive | `80.05% <ø> (?)` | |
   | javascript | `63.04% <47.16%> (+0.67%)` | :arrow_up: |
   | mysql | `80.35% <ø> (+0.04%)` | :arrow_up: |
   | postgres | `80.41% <ø> (+0.06%)` | :arrow_up: |
   | python | `80.79% <ø> (+0.36%)` | :arrow_up: |
   | sqlite | `80.02% <ø> (+0.05%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `82.05% <ø> (ø)` | |
   | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `34.95% <0.00%> (-5.62%)` | :arrow_down: |
   | [...src/SqlLab/utils/reduxStateToLocalStorageHelper.js](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9yZWR1eFN0YXRlVG9Mb2NhbFN0b3JhZ2VIZWxwZXIuanM=) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
   | [...ontend/src/common/components/InfoTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwL2luZGV4LnRzeA==) | `53.84% <ø> (ø)` | |
   | [...set-frontend/src/common/components/Modal/Modal.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsL01vZGFsLnRzeA==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [...erset-frontend/src/components/AnchorLink/index.jsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQW5jaG9yTGluay9pbmRleC5qc3g=) | `95.83% <ø> (ø)` | |
   | ... and [340 more](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=footer). Last update [e11d0cb...634233c](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] AAfghahi commented on pull request #13349: refactor: Share sql lab query

Posted by GitBox <gi...@apache.org>.
AAfghahi commented on pull request #13349:
URL: https://github.com/apache/superset/pull/13349#issuecomment-789399649


   > @AAfghahi is this one ready for another look?
   
   Yes, it should be.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13349: refactor: Share sql lab query

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13349:
URL: https://github.com/apache/superset/pull/13349#issuecomment-786319321


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=h1) Report
   > Merging [#13349](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=desc) (b785d62) into [master](https://codecov.io/gh/apache/superset/commit/b5379bc8c5312c266f777452967abfc6cb9354f8?el=desc) (b5379bc) will **decrease** coverage by `4.79%`.
   > The diff coverage is `60.34%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13349/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13349      +/-   ##
   ==========================================
   - Coverage   77.19%   72.40%   -4.80%     
   ==========================================
     Files         864      583     -281     
     Lines       44921    21236   -23685     
     Branches     5403     5505     +102     
   ==========================================
   - Hits        34677    15375   -19302     
   + Misses      10121     5738    -4383     
     Partials      123      123              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `58.09% <22.50%> (-0.45%)` | :arrow_down: |
   | javascript | `62.54% <60.00%> (+0.30%)` | :arrow_up: |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `44.70% <ø> (-24.28%)` | :arrow_down: |
   | [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `64.15% <0.00%> (+4.50%)` | :arrow_up: |
   | [...rc/common/components/Collapse/Collapse.stories.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0NvbGxhcHNlL0NvbGxhcHNlLnN0b3JpZXMudHN4) | `0.00% <0.00%> (ø)` | |
   | [...-frontend/src/common/components/Collapse/index.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0NvbGxhcHNlL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <ø> (ø)` | |
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...mponents/AsyncAceEditor/AsyncAceEditor.stories.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNBY2VFZGl0b3IvQXN5bmNBY2VFZGl0b3Iuc3Rvcmllcy50c3g=) | `0.00% <0.00%> (ø)` | |
   | [...t-frontend/src/components/AsyncAceEditor/index.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNBY2VFZGl0b3IvaW5kZXgudHN4) | `87.75% <ø> (ø)` | |
   | [...rset-frontend/src/components/DeleteModal/index.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGVsZXRlTW9kYWwvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [...et-frontend/src/components/Icons/icons.stories.jsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvaWNvbnMuc3Rvcmllcy5qc3g=) | `0.00% <0.00%> (ø)` | |
   | ... and [358 more](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=footer). Last update [b5379bc...7b54138](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13349: refactor: Share sql lab query

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13349:
URL: https://github.com/apache/superset/pull/13349#issuecomment-786319321


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=h1) Report
   > Merging [#13349](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=desc) (4de6040) into [master](https://codecov.io/gh/apache/superset/commit/e11d0cbf44e9bd1115ae01676c1d9a5d51d56990?el=desc) (e11d0cb) will **decrease** coverage by `0.08%`.
   > The diff coverage is `53.15%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13349/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13349      +/-   ##
   ==========================================
   - Coverage   76.87%   76.79%   -0.09%     
   ==========================================
     Files         880      912      +32     
     Lines       45491    46448     +957     
     Branches     5380     5645     +265     
   ==========================================
   + Hits        34973    35668     +695     
   - Misses      10395    10640     +245     
   - Partials      123      140      +17     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `60.48% <38.24%> (+2.41%)` | :arrow_up: |
   | hive | `80.05% <ø> (?)` | |
   | javascript | `63.04% <47.16%> (+0.67%)` | :arrow_up: |
   | mysql | `80.35% <ø> (+0.04%)` | :arrow_up: |
   | postgres | `80.41% <ø> (+0.06%)` | :arrow_up: |
   | python | `80.79% <ø> (+0.36%)` | :arrow_up: |
   | sqlite | `80.02% <ø> (+0.05%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...erset-frontend/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NvdXRoUGFuZS5qc3g=) | `82.05% <ø> (ø)` | |
   | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `34.95% <0.00%> (-5.62%)` | :arrow_down: |
   | [...src/SqlLab/utils/reduxStateToLocalStorageHelper.js](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi91dGlscy9yZWR1eFN0YXRlVG9Mb2NhbFN0b3JhZ2VIZWxwZXIuanM=) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...nd/src/common/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Nyb25QaWNrZXIvQ3JvblBpY2tlci50c3g=) | `100.00% <ø> (ø)` | |
   | [...ontend/src/common/components/InfoTooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwL2luZGV4LnRzeA==) | `53.84% <ø> (ø)` | |
   | [...set-frontend/src/common/components/Modal/Modal.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsL01vZGFsLnRzeA==) | `100.00% <ø> (ø)` | |
   | [...components/AlteredSliceTag/AlteredSliceTagMocks.js](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL0FsdGVyZWRTbGljZVRhZ01vY2tzLmpz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/components/AlteredSliceTag/index.jsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnL2luZGV4LmpzeA==) | `98.66% <ø> (ø)` | |
   | [...erset-frontend/src/components/AnchorLink/index.jsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQW5jaG9yTGluay9pbmRleC5qc3g=) | `95.83% <ø> (ø)` | |
   | ... and [340 more](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=footer). Last update [e11d0cb...9f5aa75](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #13349: refactor: Share sql lab query

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13349:
URL: https://github.com/apache/superset/pull/13349#issuecomment-786319321


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=h1) Report
   > Merging [#13349](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=desc) (b785d62) into [master](https://codecov.io/gh/apache/superset/commit/b5379bc8c5312c266f777452967abfc6cb9354f8?el=desc) (b5379bc) will **decrease** coverage by `4.79%`.
   > The diff coverage is `60.34%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13349/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13349      +/-   ##
   ==========================================
   - Coverage   77.19%   72.40%   -4.80%     
   ==========================================
     Files         864      583     -281     
     Lines       44921    21236   -23685     
     Branches     5403     5505     +102     
   ==========================================
   - Hits        34677    15375   -19302     
   + Misses      10121     5738    -4383     
     Partials      123      123              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `58.09% <22.50%> (-0.45%)` | :arrow_down: |
   | javascript | `62.54% <60.00%> (+0.30%)` | :arrow_up: |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `44.70% <ø> (-24.28%)` | :arrow_down: |
   | [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `64.15% <0.00%> (+4.50%)` | :arrow_up: |
   | [...rc/common/components/Collapse/Collapse.stories.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0NvbGxhcHNlL0NvbGxhcHNlLnN0b3JpZXMudHN4) | `0.00% <0.00%> (ø)` | |
   | [...-frontend/src/common/components/Collapse/index.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0NvbGxhcHNlL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <ø> (ø)` | |
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...mponents/AsyncAceEditor/AsyncAceEditor.stories.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNBY2VFZGl0b3IvQXN5bmNBY2VFZGl0b3Iuc3Rvcmllcy50c3g=) | `0.00% <0.00%> (ø)` | |
   | [...t-frontend/src/components/AsyncAceEditor/index.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNBY2VFZGl0b3IvaW5kZXgudHN4) | `87.75% <ø> (ø)` | |
   | [...rset-frontend/src/components/DeleteModal/index.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGVsZXRlTW9kYWwvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | [...et-frontend/src/components/Icons/icons.stories.jsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvaWNvbnMuc3Rvcmllcy5qc3g=) | `0.00% <0.00%> (ø)` | |
   | ... and [358 more](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=footer). Last update [b5379bc...3342a00](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on a change in pull request #13349: refactor: Share sql lab query

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13349:
URL: https://github.com/apache/superset/pull/13349#discussion_r584026496



##########
File path: superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx
##########
@@ -30,17 +29,17 @@ import { storeQuery } from 'src/utils/common';
 import { getClientErrorObject } from 'src/utils/getClientErrorObject';
 import { FeatureFlag, isFeatureEnabled } from '../../featureFlags';
 
-const propTypes = {
-  queryEditor: PropTypes.shape({
-    dbId: PropTypes.number,
-    title: PropTypes.string,
-    schema: PropTypes.string,
-    autorun: PropTypes.bool,
-    sql: PropTypes.string,
-    remoteId: PropTypes.number,
-  }).isRequired,
-  addDangerToast: PropTypes.func.isRequired,
-};
+interface propTypes {
+  queryEditor: {
+    dbId: number;
+    title: string;
+    schema: string;
+    autorun: boolean;
+    sql: string;
+    remoteId: number;
+  };
+  addDangerToast: (msg: string) => void;

Review comment:
       oh, and this one. the rest we can mark optional or null




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on a change in pull request #13349: refactor: Share sql lab query

Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #13349:
URL: https://github.com/apache/superset/pull/13349#discussion_r584026333



##########
File path: superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx
##########
@@ -30,17 +29,17 @@ import { storeQuery } from 'src/utils/common';
 import { getClientErrorObject } from 'src/utils/getClientErrorObject';
 import { FeatureFlag, isFeatureEnabled } from '../../featureFlags';
 
-const propTypes = {
-  queryEditor: PropTypes.shape({
-    dbId: PropTypes.number,
-    title: PropTypes.string,
-    schema: PropTypes.string,
-    autorun: PropTypes.bool,
-    sql: PropTypes.string,
-    remoteId: PropTypes.number,
-  }).isRequired,
-  addDangerToast: PropTypes.func.isRequired,
-};
+interface propTypes {

Review comment:
       `ShareSqlLabQueryPropTypes`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13349: refactor: Share sql lab query

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13349:
URL: https://github.com/apache/superset/pull/13349#issuecomment-786319321


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=h1) Report
   > Merging [#13349](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=desc) (7b54138) into [master](https://codecov.io/gh/apache/superset/commit/b5379bc8c5312c266f777452967abfc6cb9354f8?el=desc) (b5379bc) will **decrease** coverage by `19.59%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13349/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #13349       +/-   ##
   ===========================================
   - Coverage   77.19%   57.60%   -19.60%     
   ===========================================
     Files         864      457      -407     
     Lines       44921    13628    -31293     
     Branches     5403     3574     -1829     
   ===========================================
   - Hits        34677     7850    -26827     
   + Misses      10121     5778     -4343     
   + Partials      123        0      -123     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `57.60% <ø> (-0.95%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rc/dashboard/util/getLayoutComponentFromChartId.js](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExheW91dENvbXBvbmVudEZyb21DaGFydElkLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL1Njb3BpbmdUcmVlLnRzeA==) | `6.25% <0.00%> (-93.75%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | ... and [791 more](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=footer). Last update [b5379bc...7b54138](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] AAfghahi closed pull request #13349: refactor: Share sql lab query

Posted by GitBox <gi...@apache.org>.
AAfghahi closed pull request #13349:
URL: https://github.com/apache/superset/pull/13349


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13349: refactor: Share sql lab query

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13349:
URL: https://github.com/apache/superset/pull/13349#issuecomment-786319321


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=h1) Report
   > Merging [#13349](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=desc) (7b54138) into [master](https://codecov.io/gh/apache/superset/commit/b5379bc8c5312c266f777452967abfc6cb9354f8?el=desc) (b5379bc) will **decrease** coverage by `19.58%`.
   > The diff coverage is `55.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13349/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #13349       +/-   ##
   ===========================================
   - Coverage   77.19%   57.61%   -19.59%     
   ===========================================
     Files         864      500      -364     
     Lines       44921    16313    -28608     
     Branches     5403     4167     -1236     
   ===========================================
   - Hits        34677     9398    -25279     
   + Misses      10121     6915     -3206     
   + Partials      123        0      -123     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `57.61% <55.00%> (-0.94%)` | :arrow_down: |
   | javascript | `?` | |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/SqlLab/components/ShareSqlLabQuery.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NoYXJlU3FsTGFiUXVlcnkudHN4) | `44.44% <55.00%> (ø)` | |
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL1Njb3BpbmdUcmVlLnRzeA==) | `6.25% <0.00%> (-93.75%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
   | [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | ... and [765 more](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=footer). Last update [b5379bc...7b54138](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] eschutho commented on pull request #13349: refactor: Share sql lab query

Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #13349:
URL: https://github.com/apache/superset/pull/13349#issuecomment-789393529


   @AAfghahi is this one ready for another look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org