You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Volodymyr Vysotskyi (JIRA)" <ji...@apache.org> on 2018/12/24 18:46:00 UTC
[jira] [Resolved] (CALCITE-2463) Silence ERROR logs from
CalciteException, SqlValidatorException
[ https://issues.apache.org/jira/browse/CALCITE-2463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Volodymyr Vysotskyi resolved CALCITE-2463.
------------------------------------------
Resolution: Fixed
Fixed in [a3711d7|https://github.com/apache/calcite/commit/a3711d78d450b7183a65e0ce695527ca92218bd8]. Thanks for the fix, [~vladimirsitnikov].
> Silence ERROR logs from CalciteException, SqlValidatorException
> ---------------------------------------------------------------
>
> Key: CALCITE-2463
> URL: https://issues.apache.org/jira/browse/CALCITE-2463
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.17.0
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
> Fix For: 1.19.0
>
>
> CalciteException and SqlValidatorException log exceptions at ERROR level.
> This is not appropriate since
> 1) the exception might be expected by the caller
> 2) exception might contain sensitive information
> 3) ERROR level is not appropriate, since error in validation does not imply business-level error.
> I suggest to remove `LOGGER.error` calls from Calcite code.
> Logging exceptions at TRACE level is fine from my point of view, so client can enable trace logging if required for debug purposes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)