You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ueshin (via GitHub)" <gi...@apache.org> on 2023/02/10 20:49:42 UTC

[GitHub] [spark] ueshin opened a new pull request, #39968: [SPARK-42265][SPARK-41820][CONNECT] Fix createTempView and its variations to work with not analyzed plans

ueshin opened a new pull request, #39968:
URL: https://github.com/apache/spark/pull/39968

   ### What changes were proposed in this pull request?
   
   Fixes `createTempView` and its variations to work with not analyzed plans.
   
   - `createTempView`
   - `createOrReplaceTempView`
   - `createGlobalTempView`
   - `createOrReplaceGlobalTempView`
   
   ### Why are the changes needed?
   
   Currently `SparkConnectPlanner` creates `CreateViewCommand` with `isAnalyzed = true`, but the child plan can be not-analyzed yet.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Users can run `createTempView` and its variations with not analyzed plans.
   
   ### How was this patch tested?
   
   Enabled the related tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #39968: [SPARK-42265][SPARK-41820][CONNECT] Fix createTempView and its variations to work with not analyzed plans

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #39968:
URL: https://github.com/apache/spark/pull/39968#issuecomment-1426903344

   Merged to master and branch-3.4.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #39968: [SPARK-42265][SPARK-41820][CONNECT] Fix createTempView and its variations to work with not analyzed plans

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #39968: [SPARK-42265][SPARK-41820][CONNECT] Fix createTempView and its variations to work with not analyzed plans
URL: https://github.com/apache/spark/pull/39968


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org