You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/20 11:37:53 UTC
[GitHub] [arrow] ggershinsky opened a new pull request #8974: ARROW-10941: Document supported Parquet encryption features
ggershinsky opened a new pull request #8974:
URL: https://github.com/apache/arrow/pull/8974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8974: ARROW-10941: [Doc] Document supported Parquet encryption features
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8974:
URL: https://github.com/apache/arrow/pull/8974#issuecomment-756296076
I've polished this a bit, rebased, and added a sidebar to navigate more easily inside the documentation page. WIll merge, thank you @ggershinsky !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #8974: ARROW-10941: [Doc] Document supported Parquet encryption features
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #8974:
URL: https://github.com/apache/arrow/pull/8974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8974: ARROW-10941: Document supported Parquet encryption features
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8974:
URL: https://github.com/apache/arrow/pull/8974#issuecomment-748597321
https://issues.apache.org/jira/browse/ARROW-10941
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thamha-emotiv commented on pull request #8974: ARROW-10941: Document supported Parquet encryption features
Posted by GitBox <gi...@apache.org>.
thamha-emotiv commented on pull request #8974:
URL: https://github.com/apache/arrow/pull/8974#issuecomment-749436160
LGTM. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kiszk commented on a change in pull request #8974: ARROW-10941: Document supported Parquet encryption features
Posted by GitBox <gi...@apache.org>.
kiszk commented on a change in pull request #8974:
URL: https://github.com/apache/arrow/pull/8974#discussion_r548955381
##########
File path: docs/source/cpp/parquet.rst
##########
@@ -244,7 +244,22 @@ Limitations
Writing or reading back FixedSizedList data with null entries is not supported.
-.. TODO: document supported encryption features
+Encryption
+----------
+
+Parquet C++ implements all features, specified in the encryption `specification <https://github.com/apache/parquet-format/blob/master/Encryption.md>`__,
+except for encryption of column index and bloom filter modules.
+
+More specifically, Parquet C++ supports
+
+* AES_GCM_V1 and AES_GCM_CTR_V1 encryption algorithms
+
+* AAD suffix for Footer, ColumnMetaData, Data Page, Dictionary Page, Data PageHeader, Dictionary PageHeader module types. ColumnIndex, OffsetIndex, BloomFilter Header, BloomFilter Bitset are not supported.
Review comment:
nit: types. -> types, ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ggershinsky commented on pull request #8974: ARROW-10941: Document supported Parquet encryption features
Posted by GitBox <gi...@apache.org>.
ggershinsky commented on pull request #8974:
URL: https://github.com/apache/arrow/pull/8974#issuecomment-748596225
@thamht4190 Can you please have a look at this? To make sure I haven't missed anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thamht4190 commented on pull request #8974: ARROW-10941: Document supported Parquet encryption features
Posted by GitBox <gi...@apache.org>.
thamht4190 commented on pull request #8974:
URL: https://github.com/apache/arrow/pull/8974#issuecomment-749436606
LGTM. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ggershinsky commented on pull request #8974: ARROW-10941: Document supported Parquet encryption features
Posted by GitBox <gi...@apache.org>.
ggershinsky commented on pull request #8974:
URL: https://github.com/apache/arrow/pull/8974#issuecomment-750774738
@thamht4190 thanks. @pitrou - ready for your review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thamha-emotiv removed a comment on pull request #8974: ARROW-10941: Document supported Parquet encryption features
Posted by GitBox <gi...@apache.org>.
thamha-emotiv removed a comment on pull request #8974:
URL: https://github.com/apache/arrow/pull/8974#issuecomment-749436160
LGTM. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org