You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/08 10:30:53 UTC

[GitHub] [superset] kgabryje opened a new pull request #12996: feat: Save datapanel state in local storage

kgabryje opened a new pull request #12996:
URL: https://github.com/apache/superset/pull/12996


   ### SUMMARY
   This PR implements persisting datapanel size  and open/close state in local storage. When user opens explore page again, state from local storage will be used; if local storage is empty, default values will be used (data panel closed, split sizes 90%/10%).
   
   CC: @junlincc @villebro
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   https://user-images.githubusercontent.com/15073128/107207795-079a5b00-6a01-11eb-9c0f-f898a122b9e4.mov
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io commented on pull request #12996: feat: Save datapanel state in local storage

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12996:
URL: https://github.com/apache/superset/pull/12996#issuecomment-775053456


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=h1) Report
   > Merging [#12996](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=desc) (9b0841c) into [master](https://codecov.io/gh/apache/superset/commit/b56aec763dbe00f4f706d434ef6420e489e082b7?el=desc) (b56aec7) will **increase** coverage by `3.08%`.
   > The diff coverage is `93.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12996/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12996      +/-   ##
   ==========================================
   + Coverage   49.59%   52.67%   +3.08%     
   ==========================================
     Files         480      480              
     Lines       17315    17314       -1     
     Branches     4485     4483       -2     
   ==========================================
   + Hits         8587     9121     +534     
   + Misses       8728     8193     -535     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `52.67% <93.75%> (+3.08%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `59.41% <85.71%> (+1.74%)` | :arrow_up: |
   | [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `55.88% <100.00%> (+2.75%)` | :arrow_up: |
   | [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.58% <100.00%> (+2.33%)` | :arrow_up: |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `52.17% <0.00%> (-11.60%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `53.41% <0.00%> (-7.46%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `18.44% <0.00%> (-5.46%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `12.70% <0.00%> (-4.92%)` | :arrow_down: |
   | [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `78.65% <0.00%> (+0.60%)` | :arrow_up: |
   | ... and [60 more](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=footer). Last update [b56aec7...575bc7c](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas merged pull request #12996: feat: Save datapanel state in local storage

Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #12996:
URL: https://github.com/apache/superset/pull/12996


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas commented on pull request #12996: feat: Save datapanel state in local storage

Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #12996:
URL: https://github.com/apache/superset/pull/12996#issuecomment-775568439


   @nikolagigic @ktmud I like that there's now a getter/setter for LocalStorage available to anything. We could use this in lots of other places (like the expanding/contracting of Explore sidebars, other collapsible things, etc). We could also extend that helper/util to fall back to Cookies if LocalStorage is not available. If there's any contention around LocalStorage or Cookies, this would also be a central place to set feature flags.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12996: feat: Save datapanel state in local storage

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12996:
URL: https://github.com/apache/superset/pull/12996#issuecomment-775053456


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=h1) Report
   > Merging [#12996](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=desc) (9b0841c) into [master](https://codecov.io/gh/apache/superset/commit/b56aec763dbe00f4f706d434ef6420e489e082b7?el=desc) (b56aec7) will **increase** coverage by `3.45%`.
   > The diff coverage is `93.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12996/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12996      +/-   ##
   ==========================================
   + Coverage   49.59%   53.04%   +3.45%     
   ==========================================
     Files         480      480              
     Lines       17315    17314       -1     
     Branches     4485     4483       -2     
   ==========================================
   + Hits         8587     9185     +598     
   + Misses       8728     8129     -599     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `53.04% <93.75%> (+3.45%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `59.41% <85.71%> (+1.74%)` | :arrow_up: |
   | [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `55.88% <100.00%> (+2.75%)` | :arrow_up: |
   | [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.58% <100.00%> (+2.33%)` | :arrow_up: |
   | [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `78.65% <0.00%> (+0.60%)` | :arrow_up: |
   | [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `66.04% <0.00%> (+1.85%)` | :arrow_up: |
   | [...rontend/src/components/ListView/Filters/Select.tsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy9TZWxlY3QudHN4) | `94.28% <0.00%> (+2.85%)` | :arrow_up: |
   | [...set-frontend/src/explore/actions/exploreActions.ts](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9leHBsb3JlQWN0aW9ucy50cw==) | `50.00% <0.00%> (+3.33%)` | :arrow_up: |
   | [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `39.65% <0.00%> (+3.44%)` | :arrow_up: |
   | ... and [55 more](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=footer). Last update [b56aec7...575bc7c](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12996: feat: Save datapanel state in local storage

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12996:
URL: https://github.com/apache/superset/pull/12996#issuecomment-775053456


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=h1) Report
   > Merging [#12996](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=desc) (575bc7c) into [master](https://codecov.io/gh/apache/superset/commit/b56aec763dbe00f4f706d434ef6420e489e082b7?el=desc) (b56aec7) will **increase** coverage by `12.20%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12996/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12996       +/-   ##
   ===========================================
   + Coverage   49.59%   61.79%   +12.20%     
   ===========================================
     Files         480      537       +57     
     Lines       17315    20128     +2813     
     Branches     4485     5258      +773     
   ===========================================
   + Hits         8587    12439     +3852     
   + Misses       8728     7475     -1253     
   - Partials        0      214      +214     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `61.79% <33.33%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `16.17% <25.00%> (-65.08%)` | :arrow_down: |
   | [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `59.41% <28.57%> (+1.74%)` | :arrow_up: |
   | [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `24.05% <42.85%> (-29.08%)` | :arrow_down: |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/views/menu.tsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL21lbnUudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/views/index.tsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2luZGV4LnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.tsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [454 more](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=footer). Last update [b56aec7...575bc7c](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on pull request #12996: feat: Save datapanel state in local storage

Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12996:
URL: https://github.com/apache/superset/pull/12996#issuecomment-775248948


   welcome back @kgabryje!!!thanks for opening the PR! we need to get you back on Slack too! 🎉 
   This is a good step! not sure if we should store table tab and page in local storage as well? @vylc wdyt? 
   
   @nikolagigic @pkdotson please help review! 
   
   https://user-images.githubusercontent.com/67837651/107244717-2f7ac600-69e3-11eb-9b68-b9ff3bd1964c.mov
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io edited a comment on pull request #12996: feat: Save datapanel state in local storage

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12996:
URL: https://github.com/apache/superset/pull/12996#issuecomment-775053456


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=h1) Report
   > Merging [#12996](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=desc) (9b0841c) into [master](https://codecov.io/gh/apache/superset/commit/b56aec763dbe00f4f706d434ef6420e489e082b7?el=desc) (b56aec7) will **increase** coverage by `3.08%`.
   > The diff coverage is `93.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12996/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12996      +/-   ##
   ==========================================
   + Coverage   49.59%   52.67%   +3.08%     
   ==========================================
     Files         480      480              
     Lines       17315    17314       -1     
     Branches     4485     4483       -2     
   ==========================================
   + Hits         8587     9121     +534     
   + Misses       8728     8193     -535     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `52.67% <93.75%> (+3.08%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `59.41% <85.71%> (+1.74%)` | :arrow_up: |
   | [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `55.88% <100.00%> (+2.75%)` | :arrow_up: |
   | [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `83.58% <100.00%> (+2.33%)` | :arrow_up: |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `52.17% <0.00%> (-11.60%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `53.41% <0.00%> (-7.46%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `18.44% <0.00%> (-5.46%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `12.70% <0.00%> (-4.92%)` | :arrow_down: |
   | [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `78.65% <0.00%> (+0.60%)` | :arrow_up: |
   | ... and [60 more](https://codecov.io/gh/apache/superset/pull/12996/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=footer). Last update [b56aec7...575bc7c](https://codecov.io/gh/apache/superset/pull/12996?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org