[GitHub] [helix] jiajunwang commented on issue #1630: Flaky test TestCrushAutoRebalanceNonRack. testLackEnoughInstances

[GitBox <gi...@apache.org>]

jiajunwang commented on issue #1630:
URL: https://github.com/apache/helix/issues/1630#issuecomment-773733776


   It seems to be a real production code issue instead of a test problem.
   If we try to drop an instance immediately after it is disabled, we may see some messages from the controller side too, right?
   
   I believe a better fix is to add a retry logic in the deleteRecursively to tolerate this situation in general. However, this is still not the proper fix. The best way is to lock the folder before delete, then remove the folder with confidence. The only downside is that this would be potentially complicated.
   
   @kaisun2000 I think it is not a good idea to change the test logic here. Since it is a good one which helps us to uncover a potential issue. Please feel free to create another issue for the proper logic fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org