You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Bruno Borges (JIRA)" <ji...@apache.org> on 2007/11/06 19:18:52 UTC

[jira] Issue Comment Edited: (WICKET-1134) Multiple abstract/implement tags instead of child/extend

    [ https://issues.apache.org/jira/browse/WICKET-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540515 ] 

miojo edited comment on WICKET-1134 at 11/6/07 10:17 AM:
----------------------------------------------------------------

This implementation can already be achieved by other means, like using abstract factory methods, panels, borders, etc. 
I don't know if adding *more* tags just to implement such functionality will make things easier for developers.

Developers will easily get lost trying to pick one of hundred methods to compose pages. Plus, Wicket's greatest feature Plain HTML is losing it's way if more tags were added.

Regards

      was (Author: miojo):
    This implementation can be achieved already by other means, like using abstract factory methods, panels, borders, etc. 
I don't know if adding *more* tags just to implement such functionality will make things easier for developers.

Developers will easily get lost trying to pick one of hundred methods to compose pages. Plus, Wicket's greatest feature Plain HTML is losing it's way if more tags were added.

Regards
  
> Multiple abstract/implement tags instead of child/extend
> --------------------------------------------------------
>
>                 Key: WICKET-1134
>                 URL: https://issues.apache.org/jira/browse/WICKET-1134
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>            Reporter: Stefan Fußenegger
>            Priority: Minor
>         Attachments: wicket-abstract-implement.patch
>
>
> The current implementation of wicket:child and wicket:extend only allows for a single extension per subpage. However, this restriction is neither mandated by java class hierarchy nor by any other reason. Therefore, it should be possible to extend the current implementation to support multiple 'abstract' sections, just like abstract methods in java classes. This could be done by replacing
> <wicket:child>
>   <wicket:extend>
>     some content
>   </wicket:extend>
> </wicket:child>
> with
> <wicket:abstract id="foo">
>   <wicket:implement id="foo">
>     some content
>   </wicket:extend>
> </wicket:child>
> (new names have been suggested in http://www.nabble.com/Multiple-%3Cwicket%3Achild--%3E-tags-on-a-single-base-page--tf4738673.html)
> A possible application is a layout with two columns, e.g. a header with navigation, a left column with sub-navigation and a right column with content (where the sub-navigation may change depending on the section. In deed, this is already possible using panels or similar means. However, it would allow to take advantage of markup inheritance only:
> BasePage extens WebPage:
> <div wicket:id="links>[some nav links here]</div>
> <div><wicket:abstract id="subNavigation">[left navigation goes here]</wicket:abstract></div>
> <div><wicket:abstract id="content">[content goes here]</wicket:abstract</div>
> SectionPage extends BasePage:
> <wicket:implement id="subNavigation">[sub navigation links here]</wicket:implement>
> FooPage extends SectionPage:
> <wicket:implement id="content">[content goes here]</wicket:implement>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.