[GitHub] [incubator-dolphinscheduler] lenboo commented on a change in pull request #4703: [1.3.5-prepare][Fix-3298][K8s]Fix task log disappear after recreating or upgrading helm release

[GitBox <gi...@apache.org>]

lenboo commented on a change in pull request #4703:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4703#discussion_r571352277



##########
File path: dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/registry/MasterRegistryTest.java
##########
@@ -55,7 +56,7 @@ public void testRegistry() throws InterruptedException {
         masterRegistry.registry();
         String masterPath = zookeeperRegistryCenter.getMasterPath();
         TimeUnit.SECONDS.sleep(masterConfig.getMasterHeartbeatInterval() + 2); //wait heartbeat info write into zk node
-        String masterNodePath = masterPath + "/" + (Constants.LOCAL_ADDRESS + ":" + masterConfig.getListenPort());
+        String masterNodePath = masterPath + "/" + (OSUtils.getAddr(Constants.LOCAL_ADDRESS, masterConfig.getListenPort()));

Review comment:
       the "/"  can be replaced to  constant variable.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org