You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by el...@apache.org on 2016/11/26 09:05:50 UTC

svn commit: r1771442 - in /directory/shared/trunk/ldap/codec/standalone/src/main/java/org/apache/directory/api/ldap/codec/standalone: CodecFactoryUtil.java StandaloneLdapApiService.java

Author: elecharny
Date: Sat Nov 26 09:05:50 2016
New Revision: 1771442

URL: http://svn.apache.org/viewvc?rev=1771442&view=rev
Log:
Fixed SonarLint warnings

Modified:
    directory/shared/trunk/ldap/codec/standalone/src/main/java/org/apache/directory/api/ldap/codec/standalone/CodecFactoryUtil.java
    directory/shared/trunk/ldap/codec/standalone/src/main/java/org/apache/directory/api/ldap/codec/standalone/StandaloneLdapApiService.java

Modified: directory/shared/trunk/ldap/codec/standalone/src/main/java/org/apache/directory/api/ldap/codec/standalone/CodecFactoryUtil.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/standalone/src/main/java/org/apache/directory/api/ldap/codec/standalone/CodecFactoryUtil.java?rev=1771442&r1=1771441&r2=1771442&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/standalone/src/main/java/org/apache/directory/api/ldap/codec/standalone/CodecFactoryUtil.java (original)
+++ directory/shared/trunk/ldap/codec/standalone/src/main/java/org/apache/directory/api/ldap/codec/standalone/CodecFactoryUtil.java Sat Nov 26 09:05:50 2016
@@ -184,7 +184,23 @@ public final class CodecFactoryUtil
     }
 
 
-    public static void loadStockExtendedOperations(
+    /**
+     * Load the standard extended operations :
+     * <ul>
+     * <li>cancel</li>
+     * <li>certGeneration</li>
+     * <li>gracefuShutdown</li>
+     * <li>storedProcedure</li>
+     * <li>gracefulDisconnect</li>
+     * <li>passwordModify</li>
+     * <li>whoAmI</li>
+     * <li>startTls</li>
+     * </ul>
+     * 
+     * @param extendendOperationsFactories The map of extended operation factories
+     * @param apiService The LdapApiService to use
+     */
+    public static void loadStockExtendedOperations( 
         Map<String, ExtendedOperationFactory> extendendOperationsFactories, LdapApiService apiService )
     {
         CancelFactory cancelFactory = new CancelFactory( apiService );

Modified: directory/shared/trunk/ldap/codec/standalone/src/main/java/org/apache/directory/api/ldap/codec/standalone/StandaloneLdapApiService.java
URL: http://svn.apache.org/viewvc/directory/shared/trunk/ldap/codec/standalone/src/main/java/org/apache/directory/api/ldap/codec/standalone/StandaloneLdapApiService.java?rev=1771442&r1=1771441&r2=1771442&view=diff
==============================================================================
--- directory/shared/trunk/ldap/codec/standalone/src/main/java/org/apache/directory/api/ldap/codec/standalone/StandaloneLdapApiService.java (original)
+++ directory/shared/trunk/ldap/codec/standalone/src/main/java/org/apache/directory/api/ldap/codec/standalone/StandaloneLdapApiService.java Sat Nov 26 09:05:50 2016
@@ -198,7 +198,7 @@ public class StandaloneLdapApiService ex
      */
     private static List<String> getControlsFromSystemProperties() throws Exception
     {
-        List<String> controlsList = new ArrayList<String>();
+        List<String> controlsList = new ArrayList<>();
 
         // Loading controls list from command line properties if it exists
         String controlsString = System.getProperty( CONTROLS_LIST );
@@ -235,7 +235,7 @@ public class StandaloneLdapApiService ex
      */
     private static List<String> getExtendedOperationsFromSystemProperties() throws Exception
     {
-        List<String> extendedOperationsList = new ArrayList<String>();
+        List<String> extendedOperationsList = new ArrayList<>();
 
         // Loading extended operations from command line properties if it exists
         String defaultExtendedOperationsList = System.getProperty( EXTENDED_OPERATIONS_LIST );
@@ -271,7 +271,7 @@ public class StandaloneLdapApiService ex
     private void loadControls( List<String> controlsList ) throws Exception
     {
         // Adding all controls
-        if ( controlsList.size() > 0 )
+        if ( !controlsList.isEmpty() )
         {
             for ( String controlFQCN : controlsList )
             {
@@ -315,7 +315,7 @@ public class StandaloneLdapApiService ex
     private void loadExtendedOperations( List<String> extendedOperationsList ) throws Exception
     {
         // Adding all extended operations
-        if ( extendedOperationsList.size() > 0 )
+        if ( !extendedOperationsList.isEmpty() )
         {
             for ( String extendedOperationFQCN : extendedOperationsList )
             {