You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/09/04 03:06:08 UTC

[GitHub] [incubator-yunikorn-site] wilfred-s commented on pull request #19: [YUNIKORN-398] Document namespace based tags

wilfred-s commented on pull request #19:
URL: https://github.com/apache/incubator-yunikorn-site/pull/19#issuecomment-686873296


   The tags that are added by the shim should not be part of the rules. The `namespace` tag is used as an example but we have not defined it anywhere, which is a problem.
   If we use a different shim than the tag will not be added. We need to find a way to document this as part of shim specific behaviour. Not sure how how we do that but can you come up with a way that we can do this properly that can handle differences between shims etc?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org