You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/07/19 21:32:00 UTC

[jira] [Commented] (AMQ-7012) Misleading error in org.apache.activemq.transport.stomp.ProtocolConverter

    [ https://issues.apache.org/jira/browse/AMQ-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549893#comment-16549893 ] 

ASF subversion and git services commented on AMQ-7012:
------------------------------------------------------

Commit 5fb470478f8511619ddf9f0725ce000756536843 in activemq's branch refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=5fb4704 ]

AMQ-7012 Fix STOMP protocol handler to log correct command names

Ensure Commands are logged correctly by the protocol converter.

> Misleading error in org.apache.activemq.transport.stomp.ProtocolConverter
> -------------------------------------------------------------------------
>
>                 Key: AMQ-7012
>                 URL: https://issues.apache.org/jira/browse/AMQ-7012
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.15.4
>            Reporter: Alvin Lin
>            Priority: Major
>
> From time to time I see the following log line for STOMP: 
>  
> {{2018-07-17 07:31:22,204 | WARN  | Exception occurred processing: <Unknown> -> org.apache.activemq.transport.stomp.ProtocolException: No subscription matched. | org.apache.activemq.transport.stomp.ProtocolConverter | ActiveMQ NIO Worker 1186}}
>  
>  
> The misleading part is "<Unknown>", the unknown is suppose to be the STOMP's action word (SEND, SUBSCRIBE etc). 
> The problem seems to be 
> {code:java}
>  org.apache.activemq.transport.stomp.ProtocolConverter.safeGetAction(){code}
> that is comparing the STOMP action word with constants defined in 
> {code:java}
> org.apache.activemq.transport.stomp.ProtocolConverter.Stomp.Commands{code}
> But for subscribe and unsubscribe the constants are defined as "SUB" and "UNSUB" which does not match the actual STOMP action verbs.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)