You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "apupier (via GitHub)" <gi...@apache.org> on 2023/10/18 11:46:30 UTC
[PR] 20008 xml tokenizer expected bodies check [camel]
apupier opened a new pull request, #11756:
URL: https://github.com/apache/camel/pull/11756
based on https://github.com/apache/camel/pull/11754
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 20008 xml tokenizer expected bodies check [camel]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on PR #11756:
URL: https://github.com/apache/camel/pull/11756#issuecomment-1768339078
the job is failing without even really starting the build:
```
Run ./mvnw -l build.log -Dquickly install
./mvnw -l build.log -Dquickly install
shell: /usr/bin/bash -e {0}
env:
MVND_OPTS: -V -e -ntp -Dmvnd.threads=[2](https://github.com/apache/camel/actions/runs/6560385887/job/17818487102?pr=11756#step:6:2) -Daether.connector.http.connectionMaxTtl=120 -Daether.connector.requestTimeout=[3](https://github.com/apache/camel/actions/runs/6560385887/job/17818487102?pr=11756#step:6:3)00000 -Daether.dependencyCollector.impl=bf -Dmaven.artifact.threads=25 -Dci.env.name=github.com -Dsurefire.rerunFailingTestsCount=2 -Dfailsafe.rerunFailingTestsCount=2
JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.8-1/x6[4](https://github.com/apache/camel/actions/runs/6560385887/job/17818487102?pr=11756#step:6:4)
JAVA_HOME_17_X[6](https://github.com/apache/camel/actions/runs/6560385887/job/17818487102?pr=11756#step:6:6)4: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/1[7](https://github.com/apache/camel/actions/runs/6560385887/job/17818487102?pr=11756#step:6:7).0.[8](https://github.com/apache/camel/actions/runs/6560385887/job/17818487102?pr=11756#step:6:9)-1/x64
Error: Process completed with exit code 1.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 20008 xml tokenizer expected bodies check [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11756:
URL: https://github.com/apache/camel/pull/11756#issuecomment-1768278288
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 20008 xml tokenizer expected bodies check [camel]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on PR #11756:
URL: https://github.com/apache/camel/pull/11756#issuecomment-1770192566
> camel-mock should not have new dependency on some xml library.
Can you provide an explanation on the reason for it? it would help to find an alternative.
> this fix should not change camel-mock
I do not see an handy solution not modifying camel-mock at all. The comparison in Camel mock is on the exact message content equality but the idea is to compare similar xml content, not string comparison. We will have to introduce something to do this kind of comparison.
The alternative would be to provide another module specific to Mock with xml content but I feel it will feel weird to have different kind of camel-mock components.
Alternative: provide a specific class doing the comparison and provided as a parameter of the method `expectedXXX`. not sure where to host this method. It can be in camel-stax for now as it is the only one used but I imagine that it could be useful for other components too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 20008 xml tokenizer expected bodies check [camel]
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #11756:
URL: https://github.com/apache/camel/pull/11756#issuecomment-1768346527
You cannot see the log, because this is reserved to PMC and committer.
```
[ERROR] /home/runner/work/camel/camel/components/camel-mock/src/main/java/org/apache/camel/component/mock/MockEndpoint.java:[817,71] cannot access org.xmlunit.builder.DifferenceEngineConfigurer
class file for org.xmlunit.builder.DifferenceEngineConfigurer not found
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 20008 xml tokenizer expected bodies check [camel]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on PR #11756:
URL: https://github.com/apache/camel/pull/11756#issuecomment-1768457734
ok, Eclipse IDE test runner was friendlier with dependencyManagement declared with test scope than Maven. I updated the branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 20008 xml tokenizer expected bodies check [camel]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier closed pull request #11756: 20008 xml tokenizer expected bodies check
URL: https://github.com/apache/camel/pull/11756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org