You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@curator.apache.org by GitBox <gi...@apache.org> on 2020/06/16 16:03:08 UTC

[GitHub] [curator] Randgalt commented on a change in pull request #367: CURATOR-574 DiscoveryService fatal error on deserializing an empty byte[] as JSON

Randgalt commented on a change in pull request #367:
URL: https://github.com/apache/curator/pull/367#discussion_r440967668



##########
File path: curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceCacheImpl.java
##########
@@ -78,7 +79,7 @@ private static ExecutorService convertThreadFactory(ThreadFactory threadFactory)
 
         this.discovery = discovery;
 
-        String path = discovery.pathForName(name);
+        path = discovery.pathForName(name);

Review comment:
       The bug might actually be in `forPathChildrenCache()` of `CuratorCacheListener`. We shouldn't have to filter the root out. I believe PathChildrenCache didn't report on the root so `forPathChildrenCache` should emulate that behavior.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org