[jira] [Commented] (FLINK-7311) refrain from using fail(Exception#getMessage()) in core memory tests

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108582#comment-16108582 ] 

ASF GitHub Bot commented on FLINK-7311:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/4446

    [FLINK-7311][tests] refrain from using `fail(Exception#getMessage())`

    ## What is the purpose of the change
    
    Refrain from using `fail(Exception#getMessage())` because it hides the exception's stack trace and is bad style.
    
    This PR is based on #4445.
    
    ## Brief change log
    
      - remove code pattern `fail(Exception#getMessage())` and let the tests throw exceptions instead
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any _new_ test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-7311

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4446.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4446
    
----
commit c62e793712effbfb53ea6442b5d714a68081f7ec
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-07-31T10:06:14Z

    [hotfix] fix some typos

commit d3c4e231a96b6ae133576a74646294749ab3809a
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-07-31T12:18:42Z

    [FLINK-7310][core] always use the HybridMemorySegment
    
    Since we'd like to use our own off-heap buffers for network communication, we
    cannot use HeapMemorySegment anymore and need to rely on HybridMemorySegment.
    We thus drop any code that loads the HeapMemorySegment (it is still available
    if needed) in favour of the HybridMemorySegment which is able to work on both
    heap and off-heap memory.
    
    For the performance penalty of this change compared to using HeapMemorySegment
    alone, see this interesting blob article (from 2015):
    https://flink.apache.org/news/2015/09/16/off-heap-memory.html

commit e1de341a82148939314a90fde6f5c289f3dc9a10
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-07-31T12:36:56Z

    [FLINK-7311][tests] refrain from using fail(Exception#getMessage())

----


> refrain from using fail(Exception#getMessage()) in core memory tests
> --------------------------------------------------------------------
>
>                 Key: FLINK-7311
>                 URL: https://issues.apache.org/jira/browse/FLINK-7311
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core, Tests
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Minor
>
> Most unit tests in the {{flink/core/memory/}} domain still relies on a code pattern like this:
> {code}
> try {
> 	// ...
> } catch (Exception e) {
> 	e.printStackTrace();
> 	fail(e.getMessage());
> }
> {code}
> This does hides the exception details and should be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)