[GitHub] [iceberg] danielcweeks edited a comment on pull request #1573: Add AWS subproject and initial S3FileIO implementation

[GitBox <gi...@apache.org>]

danielcweeks edited a comment on pull request #1573:
URL: https://github.com/apache/iceberg/pull/1573#issuecomment-709606269


   @jackye1995 and @kbendick I updated to aws java sdk v2 for almost everything.  I do feel the new api has a few rough edges compared to sdk v1 (e.g. range() specification is less intuitive, missing [URI parsing functionality like AmazonS3URI](https://github.com/aws/aws-sdk-java-v2/issues/272)), but overall it wasn't much effort.  I'm still using v1 for URI parsing (if you're aware of something better in v2, please let me know).  Turns out the tests were easier than I thought because S3Mock had a v2 client that just wasn't called out in the docs.
   
   Any feedback is appreciated.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org