[jira] [Commented] (HBASE-11442) ReplicationSourceManager doesn't cleanup the queues for recovered sources

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-11442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048305#comment-14048305 ] 

Hadoop QA commented on HBASE-11442:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12653245/HBASE-11442.patch
  against trunk revision .
  ATTACHMENT ID: 12653245

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 6 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 4 warning messages.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 13 new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +    ReplicationPeers rp1 = ReplicationFactory.getReplicationPeers(s1.getZooKeeper(), s1.getConfiguration(), s1);
+    NodeFailoverWorker w1 = manager.new NodeFailoverWorker(server.getServerName().getServerName(), rq1, rp1, new UUID(new Long(1), new Long(2)));

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 	at org.apache.hadoop.hbase.TestIOFencing.testFencingAroundCompactionAfterWALSync(TestIOFencing.java:218)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9902//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9902//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9902//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9902//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9902//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9902//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9902//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9902//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9902//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9902//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9902//console

This message is automatically generated.

> ReplicationSourceManager doesn't cleanup the queues for recovered sources
> -------------------------------------------------------------------------
>
>                 Key: HBASE-11442
>                 URL: https://issues.apache.org/jira/browse/HBASE-11442
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>            Reporter: Virag Kothari
>            Assignee: Virag Kothari
>         Attachments: HBASE-11442.patch
>
>
> Currently, ReplicationSourceManager only cleanups the queues for recovered sources when the queue is being closed. This can cause the already read WAL's files to be read again when a region server doing failover also dies. This can cause replication to possibly happen again
> For e.g lets say RS1 dies with 5 files in queue and RS2 is doing the failover. Now, lets say RS2 dies after going thru 3 files in queue and RS3 is doing the failover. In this case, RS3 will again read those 3 files as they were not removed from the queue. (Though it will read the first file from the set pos. in ZK)



--
This message was sent by Atlassian JIRA
(v6.2#6252)