You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@continuum.apache.org by ev...@apache.org on 2008/10/07 06:27:21 UTC

svn commit: r702340 - /continuum/branches/continuum-1.2.x/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java

Author: evenisse
Date: Mon Oct  6 21:27:20 2008
New Revision: 702340

URL: http://svn.apache.org/viewvc?rev=702340&view=rev
Log:
[CONTINUUM-1808] Add maven2 validation errors inthe output text field of the build result page

Modified:
    continuum/branches/continuum-1.2.x/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java

Modified: continuum/branches/continuum-1.2.x/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java
URL: http://svn.apache.org/viewvc/continuum/branches/continuum-1.2.x/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java?rev=702340&r1=702339&r2=702340&view=diff
==============================================================================
--- continuum/branches/continuum-1.2.x/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java (original)
+++ continuum/branches/continuum-1.2.x/continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/DefaultBuildController.java Mon Oct  6 21:27:20 2008
@@ -161,7 +161,9 @@
             }
             catch ( TaskExecutionException e )
             {
-                //just log the error but don't stop the build from progressing in order not to suppress any build result messages there 
+                updateBuildResult( context, ContinuumUtils.throwableToString( e ) );
+
+                //just log the error but don't stop the build from progressing in order not to suppress any build result messages there
                 getLogger().error( "Error executing action update-project-from-working-directory '", e );
             }
 
@@ -546,8 +548,8 @@
         }
 
         // Check changes
-        if ( !shouldBuild && ( ( !allChangesUnknown && !context.getScmResult().getChanges().isEmpty() )
-             || project.getExecutorId().equals( ContinuumBuildExecutorConstants.MAVEN_TWO_BUILD_EXECUTOR ) ) )
+        if ( !shouldBuild && ( ( !allChangesUnknown && !context.getScmResult().getChanges().isEmpty() ) ||
+            project.getExecutorId().equals( ContinuumBuildExecutorConstants.MAVEN_TWO_BUILD_EXECUTOR ) ) )
         {
             try
             {
@@ -558,6 +560,7 @@
             }
             catch ( Exception e )
             {
+                updateBuildResult( context, ContinuumUtils.throwableToString( e ) );
                 throw new TaskExecutionException( "Can't determine if the project should build or not", e );
             }
         }