[jira] [Commented] (PHOENIX-5674) IndexTool to not write already correct index rows

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016001#comment-17016001 ] 

Hadoop QA commented on PHOENIX-5674:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12990982/PHOENIX-5674.master.002.patch
  against master branch at commit beb6457086c8e51fc8be5eceb468a1edf8a358b7.
  ATTACHMENT ID: 12990982

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +                                   MiniBatchOperationInProgress<Mutation> miniBatchOp) throws HBaseIOException {
+            conn.createStatement().execute("CREATE VIEW " + viewFullName + " AS SELECT * FROM " + dataTableFullName);
+            conn.createStatement().execute("upsert into " + viewFullName + " values (1, 'Phoenix', 12345)");
+                    "CREATE INDEX %s ON %s (NAME) INCLUDE (ZIP) ASYNC", indexTableName, viewFullName));
+            TestUtil.addCoprocessor(conn, "_IDX_" + dataTableFullName, MutationCountingRegionObserver.class);
+            // Since all the rows are in the index table, running the index tool with the "-v BEFORE" option should
+            // No need to deserialize index maintainers when the scan is raw. Raw scan is used by partial rebuilds
+                includedColumns.add(new ColumnReference(CellUtil.cloneFamily(cell), CellUtil.cloneQualifier(cell)));
+    private byte[] commitIfReady(byte[] uuidValue, UngroupedAggregateRegionObserver.MutationList mutationList) throws IOException {
+        if (ServerUtil.readyToCommit(mutationList.size(), mutationList.byteSize(), maxBatchSize, maxBatchSizeBytes)) {

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3308//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3308//console

This message is automatically generated.

> IndexTool to not write already correct index rows
> -------------------------------------------------
>
>                 Key: PHOENIX-5674
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5674
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.15.1, 4.14.3
>            Reporter: Priyank Porwal
>            Assignee: Kadir OZDEMIR
>            Priority: Major
>             Fix For: 4.15.1, 4.14.4
>
>         Attachments: PHOENIX-5674.4.x-HBase-1.5.001.patch, PHOENIX-5674.master.001.patch, PHOENIX-5674.master.002.patch
>
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> IndexTool can avoid writing index rows if they are already consistent with data-table. This will specially be useful when rebuilding index on DR-site where indexes are replicated already, but rebuild might be needed for catchup.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)