You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2015/11/05 18:25:49 UTC

[GitHub] incubator-brooklyn pull request: tidy of HttpAssertsTest

GitHub user ahgittin opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/1005

    tidy of HttpAssertsTest

    @geomacy a few tidies to HttpAssertsTest
    
    i think this should fix the failures we've seen on hosted jenkins, which i think are due to delays cleaning up ports.
    
    however it should remain an integration test except for those which run with no delays (btw i think doing that is low priority -- good integration coverage is sufficient)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/incubator-brooklyn http-assert-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/1005.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1005
    
----
commit 734770bd570ccdb8bbe02c224b26ceb7cf625a9d
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2015-11-05T17:23:12Z

    tidy of HttpAssertsTest

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: tidy of HttpAssertsTest

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/1005


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: tidy of HttpAssertsTest

Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1005#issuecomment-154354670
  
    Thanks very much @ahgittin!   I shall treat the task of separating any "non-slow" tests from the rest as a low priority, as you say. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---