You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/10 13:52:43 UTC
[GitHub] [dubbo-getty] AlexStocks opened a new pull request #54: Rem: wQ
AlexStocks opened a new pull request #54:
URL: https://github.com/apache/dubbo-getty/pull/54
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
delete handleLoop goroutine to reduce memory pressure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-io edited a comment on pull request #54: Rem: session.wQ
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #54:
URL: https://github.com/apache/dubbo-getty/pull/54#issuecomment-742617604
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=h1) Report
> Merging [#54](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=desc) (020cac6) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/ff08429119ba3b4d1e6bbbb4166a9cdd85478b47?el=desc) (ff08429) will **increase** coverage by `2.06%`.
> The diff coverage is `54.76%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 65.83% 67.89% +2.06%
==========================================
Files 8 8
Lines 1355 1277 -78
==========================================
- Hits 892 867 -25
+ Misses 370 318 -52
+ Partials 93 92 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [client.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-Y2xpZW50Lmdv) | `67.41% <0.00%> (ø)` | |
| [options.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-b3B0aW9ucy5nbw==) | `81.25% <ø> (ø)` | |
| [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-c2VydmVyLmdv) | `65.71% <40.00%> (-0.15%)` | :arrow_down: |
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `71.13% <63.63%> (+6.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=footer). Last update [ff08429...020cac6](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-io commented on pull request #54: Rem: session.wQ
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #54:
URL: https://github.com/apache/dubbo-getty/pull/54#issuecomment-742617604
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=h1) Report
> Merging [#54](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=desc) (4aa3fc5) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/ff08429119ba3b4d1e6bbbb4166a9cdd85478b47?el=desc) (ff08429) will **increase** coverage by `1.92%`.
> The diff coverage is `60.00%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 65.83% 67.75% +1.92%
==========================================
Files 8 8
Lines 1355 1284 -71
==========================================
- Hits 892 870 -22
+ Misses 370 322 -48
+ Partials 93 92 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `70.64% <60.00%> (+5.55%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=footer). Last update [ff08429...4aa3fc5](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-io edited a comment on pull request #54: Rem: session.wQ
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #54:
URL: https://github.com/apache/dubbo-getty/pull/54#issuecomment-742617604
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=h1) Report
> Merging [#54](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=desc) (29ea6b6) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/ff08429119ba3b4d1e6bbbb4166a9cdd85478b47?el=desc) (ff08429) will **increase** coverage by `2.06%`.
> The diff coverage is `54.76%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 65.83% 67.89% +2.06%
==========================================
Files 8 8
Lines 1355 1277 -78
==========================================
- Hits 892 867 -25
+ Misses 370 318 -52
+ Partials 93 92 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [client.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-Y2xpZW50Lmdv) | `67.41% <0.00%> (ø)` | |
| [options.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-b3B0aW9ucy5nbw==) | `81.25% <ø> (ø)` | |
| [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-c2VydmVyLmdv) | `65.71% <40.00%> (-0.15%)` | :arrow_down: |
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `71.13% <63.63%> (+6.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=footer). Last update [ff08429...29ea6b6](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] georgehao commented on a change in pull request #54: Rem: session.wQ
Posted by GitBox <gi...@apache.org>.
georgehao commented on a change in pull request #54:
URL: https://github.com/apache/dubbo-getty/pull/54#discussion_r541950465
##########
File path: client.go
##########
@@ -154,7 +154,7 @@ func (c *client) dialTCP() Session {
return nil
}
if c.sslEnabled {
- if sslConfig, err := c.tlsConfigBuilder.BuildTlsConfig(); err == nil && sslConfig != nil {
+ if sslConfig, e := c.tlsConfigBuilder.BuildTlsConfig(); e == nil && sslConfig != nil {
Review comment:
这个e的命名不太好吧? 改成buildTlsConfErr ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] AlexStocks commented on a change in pull request #54: Rem: session.wQ
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #54:
URL: https://github.com/apache/dubbo-getty/pull/54#discussion_r541957924
##########
File path: client.go
##########
@@ -154,7 +154,7 @@ func (c *client) dialTCP() Session {
return nil
}
if c.sslEnabled {
- if sslConfig, err := c.tlsConfigBuilder.BuildTlsConfig(); err == nil && sslConfig != nil {
+ if sslConfig, e := c.tlsConfigBuilder.BuildTlsConfig(); e == nil && sslConfig != nil {
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-io edited a comment on pull request #54: Rem: session.wQ
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #54:
URL: https://github.com/apache/dubbo-getty/pull/54#issuecomment-742617604
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=h1) Report
> Merging [#54](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=desc) (3ab27a4) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/ff08429119ba3b4d1e6bbbb4166a9cdd85478b47?el=desc) (ff08429) will **increase** coverage by `2.08%`.
> The diff coverage is `59.37%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 65.83% 67.91% +2.08%
==========================================
Files 8 8
Lines 1355 1281 -74
==========================================
- Hits 892 870 -22
+ Misses 370 319 -51
+ Partials 93 92 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [options.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-b3B0aW9ucy5nbw==) | `81.25% <ø> (ø)` | |
| [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-c2VydmVyLmdv) | `65.86% <0.00%> (ø)` | |
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `71.13% <61.29%> (+6.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=footer). Last update [ff08429...3ab27a4](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-io edited a comment on pull request #54: Rem: session.wQ
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #54:
URL: https://github.com/apache/dubbo-getty/pull/54#issuecomment-742617604
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=h1) Report
> Merging [#54](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=desc) (29ea6b6) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/ff08429119ba3b4d1e6bbbb4166a9cdd85478b47?el=desc) (ff08429) will **increase** coverage by `2.06%`.
> The diff coverage is `54.76%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 65.83% 67.89% +2.06%
==========================================
Files 8 8
Lines 1355 1277 -78
==========================================
- Hits 892 867 -25
+ Misses 370 318 -52
+ Partials 93 92 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [client.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-Y2xpZW50Lmdv) | `67.41% <0.00%> (ø)` | |
| [options.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-b3B0aW9ucy5nbw==) | `81.25% <ø> (ø)` | |
| [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-c2VydmVyLmdv) | `65.71% <40.00%> (-0.15%)` | :arrow_down: |
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `71.13% <63.63%> (+6.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=footer). Last update [ff08429...29ea6b6](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-io edited a comment on pull request #54: Rem: session.wQ
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #54:
URL: https://github.com/apache/dubbo-getty/pull/54#issuecomment-742617604
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=h1) Report
> Merging [#54](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=desc) (1156fc6) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/ff08429119ba3b4d1e6bbbb4166a9cdd85478b47?el=desc) (ff08429) will **increase** coverage by `2.01%`.
> The diff coverage is `56.09%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 65.83% 67.84% +2.01%
==========================================
Files 8 8
Lines 1355 1278 -77
==========================================
- Hits 892 867 -25
+ Misses 370 319 -51
+ Partials 93 92 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [client.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-Y2xpZW50Lmdv) | `67.41% <0.00%> (ø)` | |
| [options.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-b3B0aW9ucy5nbw==) | `81.25% <ø> (ø)` | |
| [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-c2VydmVyLmdv) | `65.44% <50.00%> (-0.42%)` | :arrow_down: |
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `71.13% <63.63%> (+6.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=footer). Last update [ff08429...49b7f14](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-io edited a comment on pull request #54: Rem: session.wQ
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #54:
URL: https://github.com/apache/dubbo-getty/pull/54#issuecomment-742617604
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=h1) Report
> Merging [#54](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=desc) (4aa3fc5) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/ff08429119ba3b4d1e6bbbb4166a9cdd85478b47?el=desc) (ff08429) will **increase** coverage by `1.92%`.
> The diff coverage is `60.00%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 65.83% 67.75% +1.92%
==========================================
Files 8 8
Lines 1355 1284 -71
==========================================
- Hits 892 870 -22
+ Misses 370 322 -48
+ Partials 93 92 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `70.64% <60.00%> (+5.55%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=footer). Last update [ff08429...4aa3fc5](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-io edited a comment on pull request #54: Rem: session.wQ
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #54:
URL: https://github.com/apache/dubbo-getty/pull/54#issuecomment-742617604
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=h1) Report
> Merging [#54](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=desc) (3fd21e0) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/ff08429119ba3b4d1e6bbbb4166a9cdd85478b47?el=desc) (ff08429) will **increase** coverage by `1.92%`.
> The diff coverage is `60.00%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 65.83% 67.75% +1.92%
==========================================
Files 8 8
Lines 1355 1284 -71
==========================================
- Hits 892 870 -22
+ Misses 370 322 -48
+ Partials 93 92 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `70.64% <60.00%> (+5.55%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=footer). Last update [ff08429...4aa3fc5](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] AlexStocks merged pull request #54: Rem: session.wQ
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #54:
URL: https://github.com/apache/dubbo-getty/pull/54
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-io edited a comment on pull request #54: Rem: session.wQ
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #54:
URL: https://github.com/apache/dubbo-getty/pull/54#issuecomment-742617604
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-io edited a comment on pull request #54: Rem: session.wQ
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #54:
URL: https://github.com/apache/dubbo-getty/pull/54#issuecomment-742617604
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=h1) Report
> Merging [#54](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=desc) (614f0c7) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/ff08429119ba3b4d1e6bbbb4166a9cdd85478b47?el=desc) (ff08429) will **increase** coverage by `2.08%`.
> The diff coverage is `59.37%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 65.83% 67.91% +2.08%
==========================================
Files 8 8
Lines 1355 1281 -74
==========================================
- Hits 892 870 -22
+ Misses 370 319 -51
+ Partials 93 92 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [options.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-b3B0aW9ucy5nbw==) | `81.25% <ø> (ø)` | |
| [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-c2VydmVyLmdv) | `65.86% <0.00%> (ø)` | |
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `71.13% <61.29%> (+6.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=footer). Last update [ff08429...614f0c7](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-io edited a comment on pull request #54: Rem: session.wQ
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #54:
URL: https://github.com/apache/dubbo-getty/pull/54#issuecomment-742617604
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=h1) Report
> Merging [#54](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=desc) (f3a7f66) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/ff08429119ba3b4d1e6bbbb4166a9cdd85478b47?el=desc) (ff08429) will **increase** coverage by `2.01%`.
> The diff coverage is `58.97%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 65.83% 67.84% +2.01%
==========================================
Files 8 8
Lines 1355 1278 -77
==========================================
- Hits 892 867 -25
+ Misses 370 319 -51
+ Partials 93 92 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [client.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-Y2xpZW50Lmdv) | `67.41% <0.00%> (ø)` | |
| [options.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-b3B0aW9ucy5nbw==) | `81.25% <ø> (ø)` | |
| [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-c2VydmVyLmdv) | `65.44% <50.00%> (-0.42%)` | :arrow_down: |
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `71.13% <67.74%> (+6.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=footer). Last update [ff08429...49b7f14](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-io edited a comment on pull request #54: Rem: session.wQ
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #54:
URL: https://github.com/apache/dubbo-getty/pull/54#issuecomment-742617604
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=h1) Report
> Merging [#54](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=desc) (49b7f14) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/ff08429119ba3b4d1e6bbbb4166a9cdd85478b47?el=desc) (ff08429) will **increase** coverage by `2.01%`.
> The diff coverage is `56.09%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 65.83% 67.84% +2.01%
==========================================
Files 8 8
Lines 1355 1278 -77
==========================================
- Hits 892 867 -25
+ Misses 370 319 -51
+ Partials 93 92 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [client.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-Y2xpZW50Lmdv) | `67.41% <0.00%> (ø)` | |
| [options.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-b3B0aW9ucy5nbw==) | `81.25% <ø> (ø)` | |
| [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-c2VydmVyLmdv) | `65.44% <50.00%> (-0.42%)` | :arrow_down: |
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `71.13% <63.63%> (+6.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=footer). Last update [ff08429...49b7f14](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-io edited a comment on pull request #54: Rem: session.wQ
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #54:
URL: https://github.com/apache/dubbo-getty/pull/54#issuecomment-742617604
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=h1) Report
> Merging [#54](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=desc) (528a348) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/ff08429119ba3b4d1e6bbbb4166a9cdd85478b47?el=desc) (ff08429) will **increase** coverage by `1.92%`.
> The diff coverage is `68.18%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 65.83% 67.75% +1.92%
==========================================
Files 8 8
Lines 1355 1284 -71
==========================================
- Hits 892 870 -22
+ Misses 370 322 -48
+ Partials 93 92 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `70.64% <68.18%> (+5.55%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=footer). Last update [ff08429...4aa3fc5](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] watermelo commented on a change in pull request #54: Rem: session.wQ
Posted by GitBox <gi...@apache.org>.
watermelo commented on a change in pull request #54:
URL: https://github.com/apache/dubbo-getty/pull/54#discussion_r540319957
##########
File path: session.go
##########
@@ -943,25 +837,20 @@ func (s *session) stop() {
func (s *session) gc() {
var (
- wQ chan interface{}
conn Connection
)
s.lock.Lock()
if s.attrs != nil {
s.attrs = nil
- if s.wQ != nil {
- wQ = s.wQ
- s.wQ = nil
- }
conn = s.Connection
+ s.Connection = nil
}
s.lock.Unlock()
go func() {
- if wQ != nil {
+ if conn != nil {
Review comment:
The next line `conn.close((int)((int64)(s.wait)))` -> `conn.close((int)(s.wait))`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] watermelo commented on a change in pull request #54: Rem: session.wQ
Posted by GitBox <gi...@apache.org>.
watermelo commented on a change in pull request #54:
URL: https://github.com/apache/dubbo-getty/pull/54#discussion_r540319957
##########
File path: session.go
##########
@@ -943,25 +837,20 @@ func (s *session) stop() {
func (s *session) gc() {
var (
- wQ chan interface{}
conn Connection
)
s.lock.Lock()
if s.attrs != nil {
s.attrs = nil
- if s.wQ != nil {
- wQ = s.wQ
- s.wQ = nil
- }
conn = s.Connection
+ s.Connection = nil
}
s.lock.Unlock()
go func() {
- if wQ != nil {
+ if conn != nil {
Review comment:
`conn.close((int)((int64)(s.wait)))` -> `conn.close((int)(s.wait))`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-io edited a comment on pull request #54: Rem: session.wQ
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #54:
URL: https://github.com/apache/dubbo-getty/pull/54#issuecomment-742617604
# [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=h1) Report
> Merging [#54](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=desc) (4872444) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/ff08429119ba3b4d1e6bbbb4166a9cdd85478b47?el=desc) (ff08429) will **increase** coverage by `1.92%`.
> The diff coverage is `61.29%`.
[](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 65.83% 67.75% +1.92%
==========================================
Files 8 8
Lines 1355 1284 -71
==========================================
- Hits 892 870 -22
+ Misses 370 322 -48
+ Partials 93 92 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/54/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `70.64% <61.29%> (+5.55%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=footer). Last update [ff08429...4872444](https://codecov.io/gh/apache/dubbo-getty/pull/54?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org