You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by dossett <gi...@git.apache.org> on 2015/11/03 16:33:16 UTC
[GitHub] storm pull request: STORM-1161: Add License headers and add rat ch...
GitHub user dossett opened a pull request:
https://github.com/apache/storm/pull/846
STORM-1161: Add License headers and add rat checks to builds
This moves Apache Rat out of the release profile and into the standard build process. It will add a slight amount of time to builds for the benefit of more frequent and thorough license audits.
I also updated 16 files with the appropriate license header.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dossett/storm STORM-1161
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/846.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #846
----
commit 808da9ae9363d36e88511282869dd7c95caa6847
Author: Aaron Dossett <aa...@target.com>
Date: 2015-11-03T15:31:13Z
STORM-1161: Add License headers and add rat checks to builds
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1161: Add License headers and add rat ch...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-153458658
@dossett none of us have permission for those files, in fact they are probably gone by now. Travis only saves what was output to the log. You could put in something in the ./dev-tools/travis that will spit out the contents of rat.txt files if the build fails because of rat.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1161: Add License headers and add rat ch...
Posted by redsanket <gi...@git.apache.org>.
Github user redsanket commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-153397013
+1 NB
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1161: Add License headers and add rat ch...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-153390872
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1161: Add License headers and add rat ch...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-153887348
@dossett Yes. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1161: Add License headers and add rat ch...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-153818109
Yes I am +1. It looks great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1161: Add License headers and add rat ch...
Posted by dossett <gi...@git.apache.org>.
Github user dossett commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-153479198
I found the storm-hive issue. The remaining java7 failure appears unrelated to these changes and java8 build was successful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1161: Add License headers and add rat ch...
Posted by dossett <gi...@git.apache.org>.
Github user dossett commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-153798617
@revans2 @ptgoetz @redsanket Are you still +1 on this change? I added the small travis step of printing file names with failed licenses since your vote.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1161: Add License headers and add rat ch...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-153402017
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1161: Add License headers and add rat ch...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/846
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1161: Add License headers and add rat ch...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-154439175
Still +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1161: Add License headers and add rat ch...
Posted by dossett <gi...@git.apache.org>.
Github user dossett commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-153472536
Thanks @revans2, I'm learning a lot today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1161: Add License headers and add rat ch...
Posted by dossett <gi...@git.apache.org>.
Github user dossett commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-153457771
Travis says that storm-hive failed the rat check. Can someone show me the contents of "/home/travis/build/apache/storm/external/storm-hive/target/rat.txt" ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1161: Add License headers and add rat ch...
Posted by dossett <gi...@git.apache.org>.
Github user dossett commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-154209788
Upmerged and squashed to a single commit @revans2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1161: Add License headers and add rat ch...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/846#issuecomment-154205971
I just tried to build with this and we need to upmerge because filght.bash has been added in recently.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---