You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Suresh Srinivas (JIRA)" <ji...@apache.org> on 2009/05/22 20:40:45 UTC
[jira] Created: (HADOOP-5899) Minor - move info log to the right
place to avoid printing unnecessary log
Minor - move info log to the right place to avoid printing unnecessary log
--------------------------------------------------------------------------
Key: HADOOP-5899
URL: https://issues.apache.org/jira/browse/HADOOP-5899
Project: Hadoop Core
Issue Type: Bug
Reporter: Suresh Srinivas
Priority: Minor
Attachments: log.patch
Log below should only be printed in {{FSEditLog.processIOErros()}} encounters error condition. Currently this log is printed unnecessarily even when there is no error.
{{INFO org.apache.hadoop.hdfs.server.namenode.FSNamesystem: current list of storage dirs:....}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5899) Minor - move info log to the right
place to avoid printing unnecessary log
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-5899:
------------------------------------
Status: Patch Available (was: Open)
> Minor - move info log to the right place to avoid printing unnecessary log
> --------------------------------------------------------------------------
>
> Key: HADOOP-5899
> URL: https://issues.apache.org/jira/browse/HADOOP-5899
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Priority: Minor
> Attachments: log.patch
>
>
> Log below should only be printed in {{FSEditLog.processIOErros()}} encounters error condition. Currently this log is printed unnecessarily even when there is no error.
> {{INFO org.apache.hadoop.hdfs.server.namenode.FSNamesystem: current list of storage dirs:....}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5899) Minor - move info log to the right
place to avoid printing unnecessary log
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-5899:
------------------------------------
Attachment: log.patch
Log is moved so that it is printed only during error conditions
> Minor - move info log to the right place to avoid printing unnecessary log
> --------------------------------------------------------------------------
>
> Key: HADOOP-5899
> URL: https://issues.apache.org/jira/browse/HADOOP-5899
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Priority: Minor
> Attachments: log.patch
>
>
> Log below should only be printed in {{FSEditLog.processIOErros()}} encounters error condition. Currently this log is printed unnecessarily even when there is no error.
> {{INFO org.apache.hadoop.hdfs.server.namenode.FSNamesystem: current list of storage dirs:....}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5899) Minor - move info log to the right
place to avoid printing unnecessary log
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5899:
-------------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I have committed this. Thanks, Suresh!
> Minor - move info log to the right place to avoid printing unnecessary log
> --------------------------------------------------------------------------
>
> Key: HADOOP-5899
> URL: https://issues.apache.org/jira/browse/HADOOP-5899
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: log.patch
>
>
> Log below should only be printed in {{FSEditLog.processIOErros()}} encounters error condition. Currently this log is printed unnecessarily even when there is no error.
> {{INFO org.apache.hadoop.hdfs.server.namenode.FSNamesystem: current list of storage dirs:....}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5899) Minor - move info log to the right
place to avoid printing unnecessary log
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715197#action_12715197 ]
Suresh Srinivas commented on HADOOP-5899:
-----------------------------------------
Test is not included because this just move code that generates info logs. The failed tests given below are not related to this patch:
org.apache.hadoop.mapred.lib.TestCombineFileInputFormat.<init>
org.apache.hadoop.mapred.TestQueueCapacities.testMultipleQueues
> Minor - move info log to the right place to avoid printing unnecessary log
> --------------------------------------------------------------------------
>
> Key: HADOOP-5899
> URL: https://issues.apache.org/jira/browse/HADOOP-5899
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Priority: Minor
> Attachments: log.patch
>
>
> Log below should only be printed in {{FSEditLog.processIOErros()}} encounters error condition. Currently this log is printed unnecessarily even when there is no error.
> {{INFO org.apache.hadoop.hdfs.server.namenode.FSNamesystem: current list of storage dirs:....}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5899) Minor - move info log to the right
place to avoid printing unnecessary log
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714090#action_12714090 ]
Boris Shkolnik commented on HADOOP-5899:
----------------------------------------
+1
Looks good
> Minor - move info log to the right place to avoid printing unnecessary log
> --------------------------------------------------------------------------
>
> Key: HADOOP-5899
> URL: https://issues.apache.org/jira/browse/HADOOP-5899
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Priority: Minor
> Attachments: log.patch
>
>
> Log below should only be printed in {{FSEditLog.processIOErros()}} encounters error condition. Currently this log is printed unnecessarily even when there is no error.
> {{INFO org.apache.hadoop.hdfs.server.namenode.FSNamesystem: current list of storage dirs:....}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5899) Minor - move info log to the right
place to avoid printing unnecessary log
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714696#action_12714696 ]
Hadoop QA commented on HADOOP-5899:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12408831/log.patch
against trunk revision 780114.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/434/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/434/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/434/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/434/console
This message is automatically generated.
> Minor - move info log to the right place to avoid printing unnecessary log
> --------------------------------------------------------------------------
>
> Key: HADOOP-5899
> URL: https://issues.apache.org/jira/browse/HADOOP-5899
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Priority: Minor
> Attachments: log.patch
>
>
> Log below should only be printed in {{FSEditLog.processIOErros()}} encounters error condition. Currently this log is printed unnecessarily even when there is no error.
> {{INFO org.apache.hadoop.hdfs.server.namenode.FSNamesystem: current list of storage dirs:....}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5899) Minor - move info log to the right
place to avoid printing unnecessary log
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5899:
-------------------------------------------
Component/s: dfs
Fix Version/s: 0.21.0
Assignee: Suresh Srinivas
Hadoop Flags: [Reviewed]
> Minor - move info log to the right place to avoid printing unnecessary log
> --------------------------------------------------------------------------
>
> Key: HADOOP-5899
> URL: https://issues.apache.org/jira/browse/HADOOP-5899
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: log.patch
>
>
> Log below should only be printed in {{FSEditLog.processIOErros()}} encounters error condition. Currently this log is printed unnecessarily even when there is no error.
> {{INFO org.apache.hadoop.hdfs.server.namenode.FSNamesystem: current list of storage dirs:....}}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.