You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/06/25 13:59:51 UTC
[GitHub] [bookkeeper] lordcheng10 opened a new pull request, #3364: add journalCbQueueLatency
lordcheng10 opened a new pull request, #3364:
URL: https://github.com/apache/bookkeeper/pull/3364
### Motivation
add journalCbQueueLatency： Calculate the time spent in the cbThreadPool queue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3364: add journalCbQueueLatency
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3364:
URL: https://github.com/apache/bookkeeper/pull/3364#issuecomment-1172845349
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3364: add journalCbQueueLatency
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on code in PR #3364:
URL: https://github.com/apache/bookkeeper/pull/3364#discussion_r910524719
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/stats/JournalStats.java:
##########
@@ -153,6 +154,13 @@ public class JournalStats {
help = "The journal callback queue size"
)
private final Counter journalCbQueueSize;
+
+ @StatsDoc(
+ name = JOURNAL_CB_QUEUE_LATENCY,
Review Comment:
`JOURNAL_CB_QUEUED_LATENCY` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3364: add journalCbQueueLatency
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3364:
URL: https://github.com/apache/bookkeeper/pull/3364#issuecomment-1166418422
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3364: add journalCbQueueLatency
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3364:
URL: https://github.com/apache/bookkeeper/pull/3364#issuecomment-1172839409
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3364: add journalCbQueueLatency
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3364:
URL: https://github.com/apache/bookkeeper/pull/3364#issuecomment-1171925794
PTAL,thanks! @eolivelli @Shoothzj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on a diff in pull request #3364: add journalCbQueueLatency
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on code in PR #3364:
URL: https://github.com/apache/bookkeeper/pull/3364#discussion_r906753711
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/stats/JournalStats.java:
##########
@@ -153,6 +154,13 @@ public class JournalStats {
help = "The journal callback queue size"
)
private final Counter journalCbQueueSize;
+
+ @StatsDoc(
+ name = JOURNAL_CB_QUEUE_LATENCY,
+ help = "The journal callback queue size"
Review Comment:
Fixed,PTAL,thanks! @hangc0276
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java:
##########
@@ -1118,6 +1129,7 @@ journalFormatVersionToWrite, getBufferedChannelBuilder(),
if (entry != null && (!syncData || entry.ackBeforeSync)) {
toFlush.set(i, null);
numEntriesToFlush--;
+ entry.setEnqueueCbThreadPooleQueueTime(MathUtils.nowInNano());
Review Comment:
Fixed,PTAL,thanks! @hangc0276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on a diff in pull request #3364: add journalCbQueueLatency
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on code in PR #3364:
URL: https://github.com/apache/bookkeeper/pull/3364#discussion_r906753705
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java:
##########
@@ -1118,6 +1129,7 @@ journalFormatVersionToWrite, getBufferedChannelBuilder(),
if (entry != null && (!syncData || entry.ackBeforeSync)) {
toFlush.set(i, null);
numEntriesToFlush--;
+ entry.setEnqueueCbThreadPooleQueueTime(MathUtils.nowInNano());
Review Comment:
Fixed,PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #3364: add journalCbQueueLatency
Posted by GitBox <gi...@apache.org>.
eolivelli merged PR #3364:
URL: https://github.com/apache/bookkeeper/pull/3364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3364: add journalCbQueueLatency
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3364:
URL: https://github.com/apache/bookkeeper/pull/3364#issuecomment-1168569912
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on a diff in pull request #3364: add journalCbQueueLatency
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on code in PR #3364:
URL: https://github.com/apache/bookkeeper/pull/3364#discussion_r911591153
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/stats/JournalStats.java:
##########
@@ -153,6 +154,13 @@ public class JournalStats {
help = "The journal callback queue size"
)
private final Counter journalCbQueueSize;
+
+ @StatsDoc(
+ name = JOURNAL_CB_QUEUE_LATENCY,
Review Comment:
Fixed,PTAL! @hangc0276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3364: add journalCbQueueLatency
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3364:
URL: https://github.com/apache/bookkeeper/pull/3364#issuecomment-1176410321
@dlg99 PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3364: add journalCbQueueLatency
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3364:
URL: https://github.com/apache/bookkeeper/pull/3364#issuecomment-1173050529
@Shoothzj PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3364: add journalCbQueueLatency
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on code in PR #3364:
URL: https://github.com/apache/bookkeeper/pull/3364#discussion_r906748686
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/stats/JournalStats.java:
##########
@@ -153,6 +154,13 @@ public class JournalStats {
help = "The journal callback queue size"
)
private final Counter journalCbQueueSize;
+
+ @StatsDoc(
+ name = JOURNAL_CB_QUEUE_LATENCY,
+ help = "The journal callback queue size"
Review Comment:
`The journal callback queued latency` ?
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java:
##########
@@ -1118,6 +1129,7 @@ journalFormatVersionToWrite, getBufferedChannelBuilder(),
if (entry != null && (!syncData || entry.ackBeforeSync)) {
toFlush.set(i, null);
numEntriesToFlush--;
+ entry.setEnqueueCbThreadPooleQueueTime(MathUtils.nowInNano());
Review Comment:
It only records the ack without flush items, we should also record the flushed items when `syncData = true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3364: add journalCbQueueLatency
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3364:
URL: https://github.com/apache/bookkeeper/pull/3364#issuecomment-1166547583
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3364: add journalCbQueueLatency
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3364:
URL: https://github.com/apache/bookkeeper/pull/3364#issuecomment-1167690086
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3364: add journalCbQueueLatency
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3364:
URL: https://github.com/apache/bookkeeper/pull/3364#issuecomment-1168633616
@eolivelli PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3364: add journalCbQueueLatency
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3364:
URL: https://github.com/apache/bookkeeper/pull/3364#issuecomment-1166322114
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on a diff in pull request #3364: add journalCbQueueLatency
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on code in PR #3364:
URL: https://github.com/apache/bookkeeper/pull/3364#discussion_r911588150
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/stats/JournalStats.java:
##########
@@ -153,6 +154,13 @@ public class JournalStats {
help = "The journal callback queue size"
)
private final Counter journalCbQueueSize;
+
+ @StatsDoc(
+ name = JOURNAL_CB_QUEUE_LATENCY,
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lordcheng10 commented on pull request #3364: add journalCbQueueLatency
Posted by GitBox <gi...@apache.org>.
lordcheng10 commented on PR #3364:
URL: https://github.com/apache/bookkeeper/pull/3364#issuecomment-1175050003
@zymap PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org