[jira] [Commented] (SSHD-1035) Move property definitions to FactoryManager

["Guillaume Nodet (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SSHD-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158710#comment-17158710 ] 

Guillaume Nodet commented on SSHD-1035:
---------------------------------------

One possibility to make sure that they are all centralized would be to define an enum and use it in {{PropertyResolver}} instead of a {{String}} as the property key.

> Move property definitions to FactoryManager
> -------------------------------------------
>
>                 Key: SSHD-1035
>                 URL: https://issues.apache.org/jira/browse/SSHD-1035
>             Project: MINA SSHD
>          Issue Type: New Feature
>            Reporter: Guillaume Nodet
>            Priority: Major
>
> There are a bunch of properties (and their default values) which are defined on various places.  This makes finding configurable properties almost impossible.
> * {{InvertedShellWrapper.PUMP_SLEEP_TIME}}
> * {{SshAgentServer.CHANNEL_OPEN_TIMEOUT_PROP}}
> * {{DefaultForwardingFilter.FORWARD_REQUEST_TIMEOUT}}
> * {{SessionHeartbeatController.SESSION_HEARTBEAT_TYPE}}
> * {{SessionHeartbeatController.SESSION_HEARTBEAT_INTERVAL}}
> * {{ScpClient.SCP_EXEC_CHANNEL_OPEN_TIMEOUT}}
> * {{ScpClient.SCP_EXEC_CHANNEL_EXIT_STATUS_TIMEOUT}}
> * {{SftpClient.NAME_DECODING_CHARSET}}
> * {{SftpFileSystemProvider.[.*]_PROP_NAME}}
> * {{ClientAuthenticationManager.PREFERRED_AUTHS}}
> * {{ClientAuthenticationManager.PASSWORD_PROMPTS}}
> * {{BufferUtils.HEXDUMP_CHUNK_SIZE}}
> * {{AgentServerProxy.AUTH_SOCKET_TIMEOUT}}
> * {{X11ForwardSupport.CHANNEL_OPEN_TIMEOUT_PROP}}
> * {{X11ForwardSupport.X11_[.*]}}
> * {{SftpRemotePathChannel.COPY_BUFSIZE_PROP}}
> * {{AbstractConnectionService.MAX_CONCURRENT_CHANNELS_PROP}}
> * ...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org