You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/05 13:00:30 UTC

[GitHub] [cloudstack] GutoVeronezi opened a new pull request #5282: Fix regression on create volume from snapshot

GutoVeronezi opened a new pull request #5282:
URL: https://github.com/apache/cloudstack/pull/5282


   ### Description
   PR #4640 added a condition validating if the VM is from hypervisor VMWare, in `AbstractStoragePoolAllocator::reorderPools(List<StoragePool>, VirtualMachineProfile, DeploymentPlan, DiskProfile)`.
   https://github.com/apache/cloudstack/blob/450de92e6cdc6d5611ca4ba701660826d6c70141/engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java#L188-L191
   
   However, when creating a volume from a snapshot (without VM's id), ACS instantiates the VirtualMachineProfile without a VM:
   
   https://github.com/apache/cloudstack/blob/75a2c0bd995abc39d02a82c96664f2aecac426d8/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java#L434
   
   Which cause a NPE on:
   https://github.com/apache/cloudstack/blob/450de92e6cdc6d5611ca4ba701660826d6c70141/engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java#L188
   
   The NPE is catch and throwed as a `CloudRuntimeException`.
   
   This PR intends to add a validation if the VM is null before validating its hypervisor.
   
   ### Types of changes
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   ### How Has This Been Tested?
   It has been tested locally in a test lab.
   1. I created VM;
   2. I took a snapshot;
   3. I tried to create a volume from the snapshot.
      - Before the nulls validation, it would throw an exception:
   ```
   ERROR [c.c.a.ApiAsyncJobDispatcher] (API-Job-Executor-1:ctx-7ec7e521 job-18849) (logid:43e9eb75) Unexpected exception while executing org.apache.cloudstack.api.command.admin.volume.CreateVolumeCmdByAdmin
   com.cloud.utils.exception.CloudRuntimeException: Failed to create volume: xxxx
       at com.cloud.storage.VolumeApiServiceImpl.createVolume(VolumeApiServiceImpl.java:901)
       at com.cloud.storage.VolumeApiServiceImpl.createVolume(VolumeApiServiceImpl.java:201)
   ```
      - After the nulls validation, it created the volume.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5282: Fix regression on create volume from snapshot

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5282:
URL: https://github.com/apache/cloudstack/pull/5282#issuecomment-894308909


   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5282: Fix regression on create volume from snapshot

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #5282:
URL: https://github.com/apache/cloudstack/pull/5282#discussion_r684144783



##########
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -898,7 +898,9 @@ public VolumeVO createVolume(CreateVolumeCmd cmd) {
             created = false;
             VolumeInfo vol = volFactory.getVolume(cmd.getEntityId());
             vol.stateTransit(Volume.Event.DestroyRequested);
-            throw new CloudRuntimeException("Failed to create volume: " + volume.getId(), e);
+            String message = String.format("Failed to create volume [%s] due to [%s].", volume.getId(), e.getMessage());
+            s_logger.error(message, e);
+            throw new CloudRuntimeException(message, e);

Review comment:
       @DaanHoogland as the real problem was not being logged, I thought it would be better to log it and keep the previous behavior. 
   
   What's your suggestion?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #5282: Fix regression on create volume from snapshot

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5282:
URL: https://github.com/apache/cloudstack/pull/5282#issuecomment-894289896


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #5282: Fix regression on create volume from snapshot

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5282:
URL: https://github.com/apache/cloudstack/pull/5282#issuecomment-894308363


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5282: Fix regression on create volume from snapshot

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5282:
URL: https://github.com/apache/cloudstack/pull/5282#issuecomment-894290298


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5282: Fix regression on create volume from snapshot

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5282:
URL: https://github.com/apache/cloudstack/pull/5282#issuecomment-894307696


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 785


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5282: Fix regression on create volume from snapshot

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5282:
URL: https://github.com/apache/cloudstack/pull/5282#discussion_r684217900



##########
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -898,7 +898,9 @@ public VolumeVO createVolume(CreateVolumeCmd cmd) {
             created = false;
             VolumeInfo vol = volFactory.getVolume(cmd.getEntityId());
             vol.stateTransit(Volume.Event.DestroyRequested);
-            throw new CloudRuntimeException("Failed to create volume: " + volume.getId(), e);
+            String message = String.format("Failed to create volume [%s] due to [%s].", volume.getId(), e.getMessage());
+            s_logger.error(message, e);
+            throw new CloudRuntimeException(message, e);

Review comment:
       A CloudRuntimeException is caught and handled somewhere so I'd just throw. The logging will be hard to find and link to the proper occurrence. If the handling code doesn't log the exception than we should fix that. We potentially get the same stacktrace twice in the log now.
   This is no :-1:  by any means by the way. I'm just not so keen on overfilling the log with the same info multiple times, It's big enough as is.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5282: Fix regression on create volume from snapshot

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #5282:
URL: https://github.com/apache/cloudstack/pull/5282#discussion_r684237387



##########
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -898,7 +898,9 @@ public VolumeVO createVolume(CreateVolumeCmd cmd) {
             created = false;
             VolumeInfo vol = volFactory.getVolume(cmd.getEntityId());
             vol.stateTransit(Volume.Event.DestroyRequested);
-            throw new CloudRuntimeException("Failed to create volume: " + volume.getId(), e);
+            String message = String.format("Failed to create volume [%s] due to [%s].", volume.getId(), e.getMessage());
+            s_logger.error(message, e);
+            throw new CloudRuntimeException(message, e);

Review comment:
       Seems fair, I will undo the last change.
   
   As the focus of this PR is not the exception handling code, I think we should create an issue to investigate it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on a change in pull request #5282: Fix regression on create volume from snapshot

Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #5282:
URL: https://github.com/apache/cloudstack/pull/5282#discussion_r683938481



##########
File path: engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
##########
@@ -185,6 +185,11 @@ public boolean configure(String name, Map<String, Object> params) throws Configu
             pools = reorderPoolsByCapacity(plan, pools);
         }
 
+        if (vmProfile.getVirtualMachine() == null) {
+            s_logger.trace("The VM is null, skipping pools reordering by disk provisioning type.");
+            return pools;
+        }
+
         if (vmProfile.getHypervisorType() == HypervisorType.VMware &&

Review comment:
       I think what @DaanHoogland meant was extending this to: `if (vmProfile.getVirtualMachine() != null && ... ` and we won't need the lines above




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] GutoVeronezi commented on pull request #5282: Fix regression on create volume from snapshot

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #5282:
URL: https://github.com/apache/cloudstack/pull/5282#issuecomment-893661966


   @DaanHoogland this is the full log of the error:
   
   ```
   2021-08-05 00:16:12,138 ERROR [c.c.a.ApiAsyncJobDispatcher] (API-Job-Executor-2:ctx-1ec8a162 job-18853) (logid:ad059be6) Unexpected exception while executing org.apache.cloudstack.api.command.admin.volume.CreateVolumeCmdByAdmin
   com.cloud.utils.exception.CloudRuntimeException: Failed to create volume: 5786
           at com.cloud.storage.VolumeApiServiceImpl.createVolume(VolumeApiServiceImpl.java:901)
           at com.cloud.storage.VolumeApiServiceImpl.createVolume(VolumeApiServiceImpl.java:201)
           at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
           at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
           at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
           at java.base/java.lang.reflect.Method.invoke(Method.java:566)
           at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
           at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
           at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
           at org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:107)
           at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:175)
           at com.cloud.event.ActionEventInterceptor.invoke(ActionEventInterceptor.java:51)
           at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:175)
           at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
           at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
           at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
           at com.sun.proxy.$Proxy227.createVolume(Unknown Source)
           at org.apache.cloudstack.api.command.user.volume.CreateVolumeCmd.execute(CreateVolumeCmd.java:225)
           at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:156)
           at com.cloud.api.ApiAsyncJobDispatcher.runJob(ApiAsyncJobDispatcher.java:108)
           at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:620)
           at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:48)
           at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)
           at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)
           at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)
           at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:45)
           at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:568)
           at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
           at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
           at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
           at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
           at java.base/java.lang.Thread.run(Thread.java:829)
   Caused by: com.cloud.utils.exception.CloudRuntimeException: Failed to create volume from snapshot:com.cloud.utils.exception.CloudRuntimeException: Failed to copy /mnt/e9ad8c2e-59f6-3886-aebd-a1c7da36028a/5769 to e5f21e96-9ee9-4f87-8b20-10b82d7dbcf6
           at org.apache.cloudstack.engine.orchestration.VolumeOrchestrator.createVolumeFromSnapshot(VolumeOrchestrator.java:494)
           at com.cloud.storage.VolumeApiServiceImpl.createVolumeFromSnapshot(VolumeApiServiceImpl.java:923)
           at com.cloud.storage.VolumeApiServiceImpl.createVolume(VolumeApiServiceImpl.java:873)
           ... 31 more
   2021-08-05 00:16:12,150 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-2:ctx-1ec8a162 job-18853) (logid:ad059be6) Complete async job-18853, jobStatus: FAILED, resultCode: 530, result: org.apache.cloudstack.api.response.ExceptionResponse/null/{"uuidList":[],"errorcode":"530","errortext":"Failed to create volume: 5786"}
   ```
   
   The NPE does not appear in the stack trace because it's being hidden; Therefore I mapped the hierarchy to facilitate the comprehension:
   
   - `VolumeApiServiceImpl::createVolume(CreateVolumeCmd)`, L873, `cmd.getVirtualMachineId()` is null, therefore it calls:
   - `VolumeApiServiceImpl::createVolumeFromSnapshot(VolumeVO, long, Long)` with a null `vmId`. As `vmId` is null, it will not instantiate `vm`. In L923, it calls: 
   - `VolumeOrchestrator::createVolumeFromSnapshot(Volume, Snapshot, UserVm)` with a null `vm`, then, in L434 it calls:
   - `VolumeOrchestrator::findStoragePool(DiskProfile, DataCenter, Pod, Long, Long, VirtualMachine, Set<StoragePool>)` with `vm` parameter null. It will instantiate a `VirtualMachineProfile` with null `vm` in L315 and in L324 it calls:
   - `AbstractStoragePoolAllocator::allocateToPool(DiskProfile, VirtualMachineProfile, DeploymentPlan, ExcludeList, int)`. In L97 it calls:
   - `AbstractStoragePoolAllocator::allocateToPool(DiskProfile, VirtualMachineProfile, DeploymentPlan, ExcludeList, int, boolean)` which, in L103, will call:
   - `AbstractStoragePoolAllocator::reorderPools(List<StoragePool>, VirtualMachineProfile, DeploymentPlan, DiskProfile)`. Here `vmProfile` is not null, but its property `_vm` is, therefore, when, in L193, it calls:
   - `VirtualMachineProfileImpl::getHypervisorType()`, it will throw a NPE due to the null `_vm`.
   
   Also, I added a commit to log the exception before throwing the `CloudRuntimeException`.
   
   ---
   About the remark, we choose to validate the `getVirtualMachine()` before the reorder block to add the log.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5282: Fix regression on create volume from snapshot

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5282:
URL: https://github.com/apache/cloudstack/pull/5282#discussion_r684217900



##########
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -898,7 +898,9 @@ public VolumeVO createVolume(CreateVolumeCmd cmd) {
             created = false;
             VolumeInfo vol = volFactory.getVolume(cmd.getEntityId());
             vol.stateTransit(Volume.Event.DestroyRequested);
-            throw new CloudRuntimeException("Failed to create volume: " + volume.getId(), e);
+            String message = String.format("Failed to create volume [%s] due to [%s].", volume.getId(), e.getMessage());
+            s_logger.error(message, e);
+            throw new CloudRuntimeException(message, e);

Review comment:
       A CloudRuntimeException is caught and handled somewhere so I'd just throw. The logging will be hard to find and link to the proper occurrence. If the handling code doesn't log the exception than we should fix that. We potentially get the same stacktrace twice in the log now.
   This is no :+1: by any means by the way. I'm just not so keen on overfilling the log with the same info multiple times, It's big enough as is.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5282: Fix regression on create volume from snapshot

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5282:
URL: https://github.com/apache/cloudstack/pull/5282#discussion_r684012655



##########
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -898,7 +898,9 @@ public VolumeVO createVolume(CreateVolumeCmd cmd) {
             created = false;
             VolumeInfo vol = volFactory.getVolume(cmd.getEntityId());
             vol.stateTransit(Volume.Event.DestroyRequested);
-            throw new CloudRuntimeException("Failed to create volume: " + volume.getId(), e);
+            String message = String.format("Failed to create volume [%s] due to [%s].", volume.getId(), e.getMessage());
+            s_logger.error(message, e);
+            throw new CloudRuntimeException(message, e);

Review comment:
       why log *and* throw? we can do with either.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #5282: Fix regression on create volume from snapshot

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5282:
URL: https://github.com/apache/cloudstack/pull/5282


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #5282: Fix regression on create volume from snapshot

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5282:
URL: https://github.com/apache/cloudstack/pull/5282#issuecomment-894094618


   good investigative work @GutoVeronezi , i have some preferences about the implementation (log when we do reorder and not when we don't) but the jist is, this is great.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #5282: Fix regression on create volume from snapshot

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5282:
URL: https://github.com/apache/cloudstack/pull/5282#issuecomment-893462718


   @GutoVeronezi a remark and a question;
   q: can you add the stack trace. I've been looking at this simple change for 15 minutes and don't see the dynamic model (dumb me)
   r: the extra block is not needed, the condition `vmProfile.getVirtualMachine() == null` can be reversed and added to the block doing the reordering.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5282: Fix regression on create volume from snapshot

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5282:
URL: https://github.com/apache/cloudstack/pull/5282#issuecomment-894614226


   <b>Trillian test result (tid-1518)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 55603 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5282-t1518-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_network.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 87 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 488.53 | test_internal_lb.py
   test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 239.44 | test_internal_lb.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 628.33 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 603.10 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 610.70 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org