You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/26 13:34:20 UTC
[GitHub] [pulsar] zhanghaou opened a new pull request #7369: Add tenant name check in list namespaces function.
zhanghaou opened a new pull request #7369:
URL: https://github.com/apache/pulsar/pull/7369
fix [https://github.com/apache/pulsar/issues/7301](https://github.com/apache/pulsar/issues/7301)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on pull request #7369: Add tenant name check in list namespaces function.
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on pull request #7369:
URL: https://github.com/apache/pulsar/pull/7369#issuecomment-650875148
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on pull request #7369: Add tenant name check in list namespaces function.
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on pull request #7369:
URL: https://github.com/apache/pulsar/pull/7369#issuecomment-650726647
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on pull request #7369: Add tenant name check in list namespaces function.
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on pull request #7369:
URL: https://github.com/apache/pulsar/pull/7369#issuecomment-650741583
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on pull request #7369: Add tenant name check in list namespaces function.
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on pull request #7369:
URL: https://github.com/apache/pulsar/pull/7369#issuecomment-650466261
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on pull request #7369: Add tenant name check in list namespaces function.
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on pull request #7369:
URL: https://github.com/apache/pulsar/pull/7369#issuecomment-650495691
@codelipenghui Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7369: Add tenant name check in list namespaces function.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7369:
URL: https://github.com/apache/pulsar/pull/7369#issuecomment-650779563
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on pull request #7369: Add tenant name check in list namespaces function.
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on pull request #7369:
URL: https://github.com/apache/pulsar/pull/7369#issuecomment-650541950
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on pull request #7369: Add tenant name check in list namespaces function.
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on pull request #7369:
URL: https://github.com/apache/pulsar/pull/7369#issuecomment-651002037
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #7369: Add tenant name check in list namespaces function.
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #7369:
URL: https://github.com/apache/pulsar/pull/7369
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on a change in pull request #7369: Add tenant name check in list namespaces function.
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on a change in pull request #7369:
URL: https://github.com/apache/pulsar/pull/7369#discussion_r446801302
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/NamespacesTest.java
##########
@@ -252,6 +252,13 @@ public void testGetNamespaces() throws Exception {
expectedList.sort(null);
assertEquals(namespaces.getTenantNamespaces(this.testTenant), expectedList);
+ try {
+ // check the tenant name is valid
+ namespaces.getTenantNamespaces(this.testTenant + "/default");
+ fail("should have failed");
+ } catch (RestException e) {
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on pull request #7369: Add tenant name check in list namespaces function.
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on pull request #7369:
URL: https://github.com/apache/pulsar/pull/7369#issuecomment-650469801
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #7369: Add tenant name check in list namespaces function.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #7369:
URL: https://github.com/apache/pulsar/pull/7369#discussion_r446663959
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/NamespacesTest.java
##########
@@ -252,6 +252,13 @@ public void testGetNamespaces() throws Exception {
expectedList.sort(null);
assertEquals(namespaces.getTenantNamespaces(this.testTenant), expectedList);
+ try {
+ // check the tenant name is valid
+ namespaces.getTenantNamespaces(this.testTenant + "/default");
+ fail("should have failed");
+ } catch (RestException e) {
Review comment:
It's better to catch the specific RestException or check the response code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou removed a comment on pull request #7369: Add tenant name check in list namespaces function.
Posted by GitBox <gi...@apache.org>.
zhanghaou removed a comment on pull request #7369:
URL: https://github.com/apache/pulsar/pull/7369#issuecomment-650541950
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org