You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/07/27 06:42:41 UTC

[GitHub] [phoenix-tephra] stoty opened a new pull request #101: TEPHRA-307 Support Hbase 2.3

stoty opened a new pull request #101:
URL: https://github.com/apache/phoenix-tephra/pull/101


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [phoenix-tephra] anew commented on a change in pull request #101: TEPHRA-307 Support Hbase 2.3

Posted by GitBox <gi...@apache.org>.
anew commented on a change in pull request #101:
URL: https://github.com/apache/phoenix-tephra/pull/101#discussion_r464468124



##########
File path: tephra-hbase-compat-2.0-base/src/test/java/org/apache/tephra/hbase/coprocessor/TransactionProcessorTest.java
##########
@@ -54,7 +54,7 @@
 import org.apache.hadoop.hbase.regionserver.RegionScanner;
 import org.apache.hadoop.hbase.regionserver.ScanType;
 import org.apache.hadoop.hbase.util.Bytes;
-import org.apache.hadoop.hbase.util.FSUtils;
+import org.apache.hadoop.hbase.util.CommonFSUtils;

Review comment:
       Nice. Better to depend on hbase-common than on hbase-server.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [phoenix-tephra] stoty commented on pull request #101: TEPHRA-307 Support Hbase 2.3

Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #101:
URL: https://github.com/apache/phoenix-tephra/pull/101#issuecomment-664292254


   This is a bit more involved than the 2.1+2.2 work was, as there are API changes (extra method in Table interface), so this is an actual new module.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [phoenix-tephra] asfgit closed pull request #101: TEPHRA-307 Support Hbase 2.3

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #101:
URL: https://github.com/apache/phoenix-tephra/pull/101


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org