You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Zhen Zhang <ne...@gmail.com> on 2015/03/12 03:28:56 UTC
Review Request 31970: [HELIX-574] fix bucketize resource bug in
current state carryover
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31970/
-----------------------------------------------------------
Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna.
Repository: helix-git
Description
-------
[HELIX-574] fix bucketize resource bug in current state carryover
One logic change is previous we don't allow drop a disabled resource. Now we change to drop a resource regardless it's disabled or not.
Diffs
-----
helix-core/src/main/java/org/apache/helix/controller/rebalancer/CustomRebalancer.java 0f3fbc4
helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/ConstraintBasedAssignment.java bab357b
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java 1bee2fe
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java 169c993
helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java 207a318
Diff: https://reviews.apache.org/r/31970/diff/
Testing
-------
Thanks,
Zhen Zhang
Re: Review Request 31970: [HELIX-574] fix bucketize resource bug in
current state carryover
Posted by Kanak Biscuitwala <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31970/#review76213
-----------------------------------------------------------
Ship it!
Ship It!
- Kanak Biscuitwala
On March 11, 2015, 10:45 p.m., Zhen Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31970/
> -----------------------------------------------------------
>
> (Updated March 11, 2015, 10:45 p.m.)
>
>
> Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna.
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> [HELIX-574] fix bucketize resource bug in current state carryover
>
> One logic change is previous we don't allow drop a disabled resource. Now we change to drop a resource regardless it's disabled or not.
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/controller/rebalancer/CustomRebalancer.java 0f3fbc4
> helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/ConstraintBasedAssignment.java bab357b
> helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java 1bee2fe
> helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java 8c9fc8d
> helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java 2b5e2bc
>
> Diff: https://reviews.apache.org/r/31970/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhen Zhang
>
>
Re: Review Request 31970: [HELIX-574] fix bucketize resource bug in
current state carryover
Posted by Zhen Zhang <ne...@gmail.com>.
> On March 12, 2015, 5:48 a.m., Kishore Gopalakrishna wrote:
> > helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java, line 190
> > <https://reviews.apache.org/r/31970/diff/1/?file=891921#file891921line190>
> >
> > Add a comment why we are doing this
will do
- Zhen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31970/#review76210
-----------------------------------------------------------
On March 12, 2015, 5:45 a.m., Zhen Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31970/
> -----------------------------------------------------------
>
> (Updated March 12, 2015, 5:45 a.m.)
>
>
> Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna.
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> [HELIX-574] fix bucketize resource bug in current state carryover
>
> One logic change is previous we don't allow drop a disabled resource. Now we change to drop a resource regardless it's disabled or not.
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/controller/rebalancer/CustomRebalancer.java 0f3fbc4
> helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/ConstraintBasedAssignment.java bab357b
> helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java 1bee2fe
> helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java 8c9fc8d
> helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java 2b5e2bc
>
> Diff: https://reviews.apache.org/r/31970/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhen Zhang
>
>
Re: Review Request 31970: [HELIX-574] fix bucketize resource bug in
current state carryover
Posted by Kishore Gopalakrishna <ki...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31970/#review76210
-----------------------------------------------------------
Ship it!
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java
<https://reviews.apache.org/r/31970/#comment123697>
will we ever see a partition in DROPPED state in the current state or we remove the entry after OFFLINE -> DROPPED is processed
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java
<https://reviews.apache.org/r/31970/#comment123696>
Add a comment why we are doing this
- Kishore Gopalakrishna
On March 12, 2015, 5:45 a.m., Zhen Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31970/
> -----------------------------------------------------------
>
> (Updated March 12, 2015, 5:45 a.m.)
>
>
> Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna.
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> [HELIX-574] fix bucketize resource bug in current state carryover
>
> One logic change is previous we don't allow drop a disabled resource. Now we change to drop a resource regardless it's disabled or not.
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/controller/rebalancer/CustomRebalancer.java 0f3fbc4
> helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/ConstraintBasedAssignment.java bab357b
> helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java 1bee2fe
> helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java 8c9fc8d
> helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java 2b5e2bc
>
> Diff: https://reviews.apache.org/r/31970/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhen Zhang
>
>
Re: Review Request 31970: [HELIX-574] fix bucketize resource bug in
current state carryover
Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31970/
-----------------------------------------------------------
(Updated March 12, 2015, 5:45 a.m.)
Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna.
Repository: helix-git
Description
-------
[HELIX-574] fix bucketize resource bug in current state carryover
One logic change is previous we don't allow drop a disabled resource. Now we change to drop a resource regardless it's disabled or not.
Diffs (updated)
-----
helix-core/src/main/java/org/apache/helix/controller/rebalancer/CustomRebalancer.java 0f3fbc4
helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/ConstraintBasedAssignment.java bab357b
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java 1bee2fe
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java 8c9fc8d
helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java 2b5e2bc
Diff: https://reviews.apache.org/r/31970/diff/
Testing
-------
Thanks,
Zhen Zhang
Re: Review Request 31970: [HELIX-574] fix bucketize resource bug in
current state carryover
Posted by Kanak Biscuitwala <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31970/#review76202
-----------------------------------------------------------
Ship it!
Ship it! (assuming tests pass)
- Kanak Biscuitwala
On March 11, 2015, 7:28 p.m., Zhen Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31970/
> -----------------------------------------------------------
>
> (Updated March 11, 2015, 7:28 p.m.)
>
>
> Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna.
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> [HELIX-574] fix bucketize resource bug in current state carryover
>
> One logic change is previous we don't allow drop a disabled resource. Now we change to drop a resource regardless it's disabled or not.
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/controller/rebalancer/CustomRebalancer.java 0f3fbc4
> helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/ConstraintBasedAssignment.java bab357b
> helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java 1bee2fe
> helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java 169c993
> helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java 207a318
>
> Diff: https://reviews.apache.org/r/31970/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhen Zhang
>
>