You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/01 11:04:16 UTC

[GitHub] [airflow] Taragolis commented on a diff in pull request #27823: Amazon Provider Package user agent

Taragolis commented on code in PR #27823:
URL: https://github.com/apache/airflow/pull/27823#discussion_r1036976868


##########
airflow/providers/amazon/aws/hooks/base_aws.py:
##########
@@ -25,9 +25,13 @@
 from __future__ import annotations
 

Review Comment:
   @ferruzzi Sorry miss notification.
   
   This more about preventing circular imports. Right now if user try to obtain _config_  from Secret Backend ([with `_secret` suffix](https://airflow.apache.org/docs/apache-airflow/stable/howto/set-config.html#setting-configuration-options)) it actually happen before some airflow modules properly imported and in this case local import might not help.
   
   It should not affect if user get _variables_ and _connections_ from Secrets Backends.
   
   That mean right now it is fine that this imports inside methods of AwsGenericHook/AwsBaseHook



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org