[GitHub] [incubator-doris] zenoyang commented on a change in pull request #8267: [fix](vectorization)Some small fix for SegmentIter Vectorization

[GitBox <gi...@apache.org>]

zenoyang commented on a change in pull request #8267:
URL: https://github.com/apache/incubator-doris/pull/8267#discussion_r816485202



##########
File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp
##########
@@ -613,10 +613,7 @@ void SegmentIterator::_vec_init_lazy_materialization() {
             _is_pred_column[cid] = true;
             pred_column_ids.insert(cid);
 
-            // for date type which can not be executed in a vectorized way, using short circuit execution
-            if (type == OLAP_FIELD_TYPE_VARCHAR || type == OLAP_FIELD_TYPE_CHAR ||
-                type == OLAP_FIELD_TYPE_DECIMAL || type == OLAP_FIELD_TYPE_DATE ||
-                predicate->is_in_predicate()) {
+            if (type == OLAP_FIELD_TYPE_VARCHAR || type == OLAP_FIELD_TYPE_CHAR || predicate->is_in_predicate()) {

Review comment:
       Why is there no OLAP_FIELD_TYPE_STRING type here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org