You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/01/20 16:47:50 UTC
[GitHub] [incubator-doris] caiconghui opened a new pull request #7821: [feature](meta) Support show compactionTooSlowTablets and largeDataSizeTablets
caiconghui opened a new pull request #7821:
URL: https://github.com/apache/incubator-doris/pull/7821
# Proposed changes
Issue Number: close #7820
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes)
2. Has unit tests been added: (No)
3. Has document been added or modified: (Yes)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7821: [feature](meta) Support show compactionTooSlowTablets and largeDataSizeTablets
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7821:
URL: https://github.com/apache/incubator-doris/pull/7821#issuecomment-1021973137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #7821: [feature](meta) Support show compactionTooSlowTablets and oversizeTablets
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #7821:
URL: https://github.com/apache/incubator-doris/pull/7821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #7821: [feature](meta) Support show compactionTooSlowTablets and largeDataSizeTablets
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #7821:
URL: https://github.com/apache/incubator-doris/pull/7821#discussion_r792379415
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/proc/StatisticProcDir.java
##########
@@ -56,6 +58,7 @@
.add("DbId").add("DbName").add("TableNum").add("PartitionNum")
.add("IndexNum").add("TabletNum").add("ReplicaNum").add("UnhealthyTabletNum")
.add("InconsistentTabletNum").add("CloningTabletNum").add("BadTabletNum")
+ .add("CompactionTooSlowTabletNum").add("LargeDataSizeTabletNum")
Review comment:
```suggestion
.add("CompactionTooSlowTabletNum").add("OversizeTablets")
```
##########
File path: docs/zh-CN/administrator-guide/config/fe_config.md
##########
@@ -2144,3 +2144,33 @@ load 标签清理器将每隔 `label_clean_interval_second` 运行一次以清
是否为 Master FE 节点独有的配置项：false
是否允许同一个 tablet 的多个副本分布在同一个 host 上。这个参数主要用于本地测试是，方便搭建多个 BE 已测试某些多副本情况。不要用于非测试环境。
+
+### min_version_count_indicate_replica_compaction_too_slow
+
+默认值：300
+
+是否可以动态配置：true
+
+是否为 Master FE 节点独有的配置项：true
+
+版本计数阈值，用来判断副本做 compaction 的速度是否太慢
+
+### valid_version_count_delta_ratio_between_replicas
+
+默认值：0.5
+
+是否可以动态配置：true
+
+是否为 Master FE 节点独有的配置项：true
+
+最慢副本的版本计数与最快副本的差异有效比率阈值，如果设置 repair_slow_replica 为 true，则用于判断是否修复最慢的副本
Review comment:
```suggestion
最慢副本的版本计数与最快副本的差异有效比率阈值，如果设置 `repair_slow_replica` 为 true，则用于判断是否修复最慢的副本
```
##########
File path: docs/en/administrator-guide/config/fe_config.md
##########
@@ -2121,3 +2121,32 @@ Only for Master FE: false
Whether to allow multiple replicas of the same tablet to be distributed on the same host. This parameter is mainly used for local testing, to facilitate building multiple BEs to test certain multi-replica situations. Do not use it for non-test environments.
+### min_version_count_indicate_replica_compaction_too_slow
+
+Default: 300
+
+Dynamically configured: true
+
+Only for Master FE: true
+
+The version count threshold used to judge whether replica compaction is too slow
+
+### valid_version_count_delta_ratio_between_replicas
+
+Default: 0.5
+
+Dynamically configured: true
+
+Only for Master FE: true
+
+The valid ratio threshold of the difference between the version count of the slowest replica and the fastest replica. If repair_slow_replica is set to true, it is used to determine whether to repair the slowest replica
Review comment:
```suggestion
The valid ratio threshold of the difference between the version count of the slowest replica and the fastest replica. If `repair_slow_replica` is set to true, it is used to determine whether to repair the slowest replica
```
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/proc/StatisticProcDir.java
##########
@@ -113,10 +116,15 @@ public ProcNodeInterface lookup(String dbIdStr) throws AnalysisException {
int inconsistentTabletNum;
int cloningTabletNum;
int badTabletNum;
+ int compactionTooSlowTabletNum;
+ int largeDataSizeTabletNum;
Review comment:
```suggestion
int oversizeTabletNum;
```
##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/proc/IncompleteTabletsProcNode.java
##########
@@ -29,6 +29,7 @@
public class IncompleteTabletsProcNode implements ProcNodeInterface {
public static final ImmutableList<String> TITLE_NAMES = new ImmutableList.Builder<String>()
.add("UnhealthyTablets").add("InconsistentTablets").add("CloningTablets").add("BadTablets")
+ .add("CompactionTooSlowTablets").add("LargeDataSizeTablets")
Review comment:
```suggestion
.add("CompactionTooSlowTablets").add("OversizeTablets")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org