You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Marton Greber (Code Review)" <ge...@cloudera.org> on 2022/08/24 13:31:01 UTC
[kudu-CR] Fix glog linker flags for ARM Mac
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18902
Change subject: Fix glog linker flags for ARM Mac
......................................................................
Fix glog linker flags for ARM Mac
"-L$PREFIX/lib" in the glog build definitions was causing SIGBUS when
doing Kudu startup, on M1 Mac. The issue is reproducible with the
logging-test:
@ 0x1a09f84e4 _sigtramp
@ 0x1a0947afc std::__1::basic_ostream<>::operator<<()
@ 0x101de0fc0 kudu::operator<<()
@ 0x100b70ab4 kudu::LoggingTest_TestThrottledLogging_Test::TestBody()
@ 0x10191ceb8 testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x10191ce00 testing::Test::Run()
@ 0x10191e460 testing::TestInfo::Run()
@ 0x10191ed78 testing::TestSuite::Run()
@ 0x10192c85c testing::internal::UnitTestImpl::RunAllTests()
@ 0x10192c0b8 testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x10192c01c testing::UnitTest::Run()
@ 0x100e20920 RUN_ALL_TESTS()
@ 0x100e20650 main
Bus error: 10
Investigations on Linux: Removing "-L$PREFIX/lib" does not affect the
glog link process. The thirdparty libunwind.so and libgflags.so are
linked correctly as well. Only the runpath has to be specified, else ldd
shows not found for libunwind.so and libgflags.so.
By removing "-L$PREFIX/lib" from the glog build definitions Kudu works
fine on my M1 Mac.
Change-Id: I3771a086dfb7caf89e9a7fc0f328e77ee7049ec5
---
M thirdparty/build-definitions.sh
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/18902/1
--
To view, visit http://gerrit.cloudera.org:8080/18902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3771a086dfb7caf89e9a7fc0f328e77ee7049ec5
Gerrit-Change-Number: 18902
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
[kudu-CR] Fix glog linker flags for ARM Mac
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18902 )
Change subject: Fix glog linker flags for ARM Mac
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3771a086dfb7caf89e9a7fc0f328e77ee7049ec5
Gerrit-Change-Number: 18902
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Aug 2022 21:08:13 +0000
Gerrit-HasComments: No
[kudu-CR] Fix glog linker flags for ARM Mac
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18902
to look at the new patch set (#2).
Change subject: Fix glog linker flags for ARM Mac
......................................................................
Fix glog linker flags for ARM Mac
"-L$PREFIX/lib" in the glog build definitions was causing SIGBUS when
doing Kudu startup, on M1 Mac. The issue is reproducible with the
logging-test:
@ 0x1a09f84e4 _sigtramp
@ 0x1a0947afc std::__1::basic_ostream<>::operator<<()
@ 0x101de0fc0 kudu::operator<<()
@ 0x100b70ab4 kudu::LoggingTest_TestThrottledLogging_Test::TestBody()
@ 0x10191ceb8 testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x10191ce00 testing::Test::Run()
@ 0x10191e460 testing::TestInfo::Run()
@ 0x10191ed78 testing::TestSuite::Run()
@ 0x10192c85c testing::internal::UnitTestImpl::RunAllTests()
@ 0x10192c0b8 testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x10192c01c testing::UnitTest::Run()
@ 0x100e20920 RUN_ALL_TESTS()
@ 0x100e20650 main
Bus error: 10
Investigations on Linux: Removing "-L$PREFIX/lib" does not affect the
glog link process. The thirdparty libunwind.so and libgflags.so are
linked correctly as well. Only the runpath has to be specified, else ldd
shows not found for libunwind.so and libgflags.so.
By removing "-L$PREFIX/lib" from the glog build definitions Kudu works
fine on my M1 Mac.
Change-Id: I3771a086dfb7caf89e9a7fc0f328e77ee7049ec5
---
M thirdparty/build-definitions.sh
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/18902/2
--
To view, visit http://gerrit.cloudera.org:8080/18902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3771a086dfb7caf89e9a7fc0f328e77ee7049ec5
Gerrit-Change-Number: 18902
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Fix glog linker flags for ARM Mac
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18902 )
Change subject: Fix glog linker flags for ARM Mac
......................................................................
Fix glog linker flags for ARM Mac
"-L$PREFIX/lib" in the glog build definitions was causing SIGBUS when
doing Kudu startup, on M1 Mac. The issue is reproducible with the
logging-test:
@ 0x1a09f84e4 _sigtramp
@ 0x1a0947afc std::__1::basic_ostream<>::operator<<()
@ 0x101de0fc0 kudu::operator<<()
@ 0x100b70ab4 kudu::LoggingTest_TestThrottledLogging_Test::TestBody()
@ 0x10191ceb8 testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x10191ce00 testing::Test::Run()
@ 0x10191e460 testing::TestInfo::Run()
@ 0x10191ed78 testing::TestSuite::Run()
@ 0x10192c85c testing::internal::UnitTestImpl::RunAllTests()
@ 0x10192c0b8 testing::internal::HandleExceptionsInMethodIfSupported<>()
@ 0x10192c01c testing::UnitTest::Run()
@ 0x100e20920 RUN_ALL_TESTS()
@ 0x100e20650 main
Bus error: 10
Investigations on Linux: Removing "-L$PREFIX/lib" does not affect the
glog link process. The thirdparty libunwind.so and libgflags.so are
linked correctly as well. Only the runpath has to be specified, else ldd
shows not found for libunwind.so and libgflags.so.
By removing "-L$PREFIX/lib" from the glog build definitions Kudu works
fine on my M1 Mac.
Change-Id: I3771a086dfb7caf89e9a7fc0f328e77ee7049ec5
Reviewed-on: http://gerrit.cloudera.org:8080/18902
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M thirdparty/build-definitions.sh
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3771a086dfb7caf89e9a7fc0f328e77ee7049ec5
Gerrit-Change-Number: 18902
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>