You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/05/31 17:46:59 UTC
[GitHub] [calcite] hsyuan commented on a change in pull request #1247:
[CALCITE-3089] Deprecate EquiJoin
hsyuan commented on a change in pull request #1247: [CALCITE-3089] Deprecate EquiJoin
URL: https://github.com/apache/calcite/pull/1247#discussion_r289489174
##########
File path: core/src/main/java/org/apache/calcite/rel/rules/FilterJoinRule.java
##########
@@ -49,7 +50,8 @@
public abstract class FilterJoinRule extends RelOptRule {
/** Predicate that always returns true. With this predicate, every filter
* will be pushed into the ON clause. */
- public static final Predicate TRUE_PREDICATE = (join, joinType, exp) -> true;
+ public static final Predicate TRUE_PREDICATE = (join, joinType, exp) ->
+ join.getConvention() != EnumerableConvention.INSTANCE;
Review comment:
This will be changed back once [CALCITE-2973](https://issues.apache.org/jira/browse/CALCITE-2973) is done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services