You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Phillips <no...@github.com> on 2014/07/28 15:49:13 UTC

[jclouds] 'iso8601DateParseWithOptionalTZ' -> 'iso8601DateOrSecondsDateParse' in DateService (#457)

Follow-up to #456 
You can merge this Pull Request by running:

  git pull https://github.com/jclouds/jclouds pr-456-follow-up

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/457

-- Commit Summary --

  * &#39;iso8601DateParseWithOptionalTZ&#39; -&gt; &#39;iso8601DateOrSecondsDateParse&#39; in DateService

-- File Changes --

    M apis/s3/src/main/java/org/jclouds/s3/xml/CopyObjectHandler.java (2)
    M apis/s3/src/main/java/org/jclouds/s3/xml/ListAllMyBucketsHandler.java (2)
    M apis/s3/src/main/java/org/jclouds/s3/xml/ListBucketHandler.java (2)
    M apis/s3/src/test/java/org/jclouds/s3/xml/CopyObjectHandlerTest.java (6)
    M apis/s3/src/test/java/org/jclouds/s3/xml/ListBucketHandlerTest.java (8)
    M core/src/main/java/org/jclouds/date/DateService.java (2)
    M core/src/main/java/org/jclouds/date/internal/SimpleDateFormatDateService.java (28)
    M core/src/test/java/org/jclouds/date/DateServiceTest.java (17)
    M drivers/joda/src/main/java/org/jclouds/date/joda/JodaDateService.java (30)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/457.patch
https://github.com/jclouds/jclouds/pull/457.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/457

Re: [jclouds] 'iso8601DateParseWithOptionalTZ' -> 'iso8601DateOrSecondsDateParse' in DateService (#457)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1037](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1037/) UNSTABLE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/457#issuecomment-50349451

Re: [jclouds] 'iso8601DateParseWithOptionalTZ' -> 'iso8601DateOrSecondsDateParse' in DateService (#457)

Posted by Andrew Phillips <no...@github.com>.
>        Date dsDate = dateService
> -            .iso8601DateParseWithOptionalTZ(testData[0].iso8601SecondsDateString);
> -      Date secondsDate = dateService
> -            .iso8601SecondsDateParse(testData[0].iso8601SecondsDateString);
> -      assertEquals(dsDate, secondsDate);
> +            .iso8601DateOrSecondsDateParse(testData[0].iso8601DateString);
> +      assertEquals(dsDate, testData[0].date);
> +
> +      Date dsSecondsDate = dateService
> +            .iso8601DateOrSecondsDateParse(testData[0].iso8601SecondsDateString);
> +      assertEquals(dsSecondsDate, testData[0].date);
> +   }
> +
> +   @Test(expectedExceptions = IllegalArgumentException.class)
> +   public void testIso8601DateOrSecondsDateParseIllegal() {
> +      dateService.iso8601DateOrSecondsDateParse("-1");

Not verifying here that it throws the _first_ exception, but I think this should be enough.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/457/files#r15462761

Re: [jclouds] 'iso8601DateParseWithOptionalTZ' -> 'iso8601DateOrSecondsDateParse' in DateService (#457)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1038](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1038/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/457#issuecomment-50351286

Re: [jclouds] 'iso8601DateParseWithOptionalTZ' -> 'iso8601DateOrSecondsDateParse' in DateService (#457)

Posted by Andrew Phillips <no...@github.com>.
>        ObjectMetadata expected = new CopyObjectResult(
>              new SimpleDateFormatDateService()
> -                  .iso8601SecondsDateParse("2014-07-23T20:53:17+0000"),
> +                  .iso8601DateOrSecondsDateParse("2014-07-23T20:53:17+0000"),

Unintentional change. Will revert.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/457/files#r15462638

Re: [jclouds] 'iso8601DateParseWithOptionalTZ' -> 'iso8601DateOrSecondsDateParse' in DateService (#457)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1510](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1510/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/457#issuecomment-50352269

Re: [jclouds] 'iso8601DateParseWithOptionalTZ' -> 'iso8601DateOrSecondsDateParse' in DateService (#457)

Posted by Andrew Phillips <no...@github.com>.
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=eba727fef7732d61af248a33ccd1b88cc5c2104e)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/457#issuecomment-50361161

Re: [jclouds] 'iso8601DateParseWithOptionalTZ' -> 'iso8601DateOrSecondsDateParse' in DateService (#457)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1434](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1434/) ABORTED

[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/457#issuecomment-50356902

Re: [jclouds] 'iso8601DateParseWithOptionalTZ' -> 'iso8601DateOrSecondsDateParse' in DateService (#457)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1509](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1509/) ABORTED


---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/457#issuecomment-50478726

Re: [jclouds] 'iso8601DateParseWithOptionalTZ' -> 'iso8601DateOrSecondsDateParse' in DateService (#457)

Posted by Andrew Phillips <no...@github.com>.
> jclouds-pull-requests #1037 UNSTABLE

Spurious [test failures](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/org.apache.jclouds$jclouds-compute/1037/testReport/junit/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/457#issuecomment-50350017

Re: [jclouds] 'iso8601DateParseWithOptionalTZ' -> 'iso8601DateOrSecondsDateParse' in DateService (#457)

Posted by Andrew Gaul <no...@github.com>.
:+1: Please propagate to 1.7.x as well.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/457#issuecomment-50355027

Re: [jclouds] 'iso8601DateParseWithOptionalTZ' -> 'iso8601DateOrSecondsDateParse' in DateService (#457)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1435](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1435/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/457#issuecomment-50363753

Re: [jclouds] 'iso8601DateParseWithOptionalTZ' -> 'iso8601DateOrSecondsDateParse' in DateService (#457)

Posted by Andrew Phillips <no...@github.com>.
@andrewgaul @shrinandj Ping...

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/457#issuecomment-50346053