[GitHub] [spark] grundprinzip commented on a diff in pull request #42929: [SPARK-45167] Python client must call `release_all`

["grundprinzip (via GitHub)" <gi...@apache.org>]

grundprinzip commented on code in PR #42929:
URL: https://github.com/apache/spark/pull/42929#discussion_r1325946271


##########
python/pyspark/sql/connect/client/reattach.py:
##########
@@ -200,9 +200,6 @@ def _release_all(self) -> None:
         This will send an asynchronous RPC which will not block this. The client continues
         executing, and if the release fails, server is equipped to deal with abandoned executions.
         """
-        if self._result_complete:
-            return

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org