You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zookeeper.apache.org by eo...@apache.org on 2019/05/25 17:43:37 UTC
[zookeeper] branch master updated: ZOOKEEPER-3399: Remove logging
in getGlobalOutstandingLimit for optimal performance.
This is an automated email from the ASF dual-hosted git repository.
eolivelli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zookeeper.git
The following commit(s) were added to refs/heads/master by this push:
new 968f5f3 ZOOKEEPER-3399: Remove logging in getGlobalOutstandingLimit for optimal performance.
968f5f3 is described below
commit 968f5f365e53d0bcbbe0225cc382327badbd8380
Author: Michael Han <lh...@twitter.com>
AuthorDate: Sat May 25 19:43:31 2019 +0200
ZOOKEEPER-3399: Remove logging in getGlobalOutstandingLimit for optimal performance.
Please refer https://issues.apache.org/jira/browse/ZOOKEEPER-3399 for detailed description. This PR removes the LOG statement which was the state of the code path before ZOOKEEPER-3177. The original patch of ZOOKEEPER-3177 had the LOG statement in right place, but that was changed in the second pull request (711) that reverted part of the original patch due to a find bug warning.
Author: Michael Han <lh...@twitter.com>
Reviewers: Enrico Olivelli <eo...@apache.org>
Closes #956 from hanm/ZOOKEEPER-3399
---
.../java/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java | 1 -
.../java/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java | 1 -
2 files changed, 2 deletions(-)
diff --git a/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java b/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java
index e153286..90013e4 100644
--- a/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java
+++ b/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java
@@ -136,7 +136,6 @@ public class FollowerZooKeeperServer extends LearnerZooKeeperServer {
public int getGlobalOutstandingLimit() {
int divisor = self.getQuorumSize() > 2 ? self.getQuorumSize() - 1 : 1;
int globalOutstandingLimit = super.getGlobalOutstandingLimit() / divisor;
- LOG.info("Override {} to {}", GLOBAL_OUTSTANDING_LIMIT, globalOutstandingLimit);
return globalOutstandingLimit;
}
diff --git a/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java b/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java
index f861dfa..d348744 100644
--- a/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java
+++ b/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java
@@ -108,7 +108,6 @@ public class LeaderZooKeeperServer extends QuorumZooKeeperServer {
public int getGlobalOutstandingLimit() {
int divisor = self.getQuorumSize() > 2 ? self.getQuorumSize() - 1 : 1;
int globalOutstandingLimit = super.getGlobalOutstandingLimit() / divisor;
- LOG.info("Override {} to {}", GLOBAL_OUTSTANDING_LIMIT, globalOutstandingLimit);
return globalOutstandingLimit;
}