You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/02/15 15:13:31 UTC
Review Request 56710: Relax ranger config DB consistency check rules
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56710/
-----------------------------------------------------------
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-20024
https://issues.apache.org/jira/browse/AMBARI-20024
Repository: ambari
Description
-------
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 878d0fa
Diff: https://reviews.apache.org/r/56710/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 56710: Relax ranger config DB consistency check
rules
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56710/
-----------------------------------------------------------
(Updated Feb. 17, 2017, 11:35 a.m.)
Review request for Ambari, Dmitro Lisnichenko and Jayush Luniya.
Bugs: AMBARI-20024
https://issues.apache.org/jira/browse/AMBARI-20024
Repository: ambari
Description
-------
.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 926ec65
Diff: https://reviews.apache.org/r/56710/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 56710: Relax ranger config DB consistency check
rules
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56710/#review165871
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On Feb. 16, 2017, 11:24 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56710/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2017, 11:24 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jayush Luniya.
>
>
> Bugs: AMBARI-20024
> https://issues.apache.org/jira/browse/AMBARI-20024
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 878d0fa
>
> Diff: https://reviews.apache.org/r/56710/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 56710: Relax ranger config DB consistency check
rules
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56710/#review165917
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 16, 2017, 1:24 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56710/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2017, 1:24 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jayush Luniya.
>
>
> Bugs: AMBARI-20024
> https://issues.apache.org/jira/browse/AMBARI-20024
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 878d0fa
>
> Diff: https://reviews.apache.org/r/56710/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 56710: Relax ranger config DB consistency check
rules
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56710/
-----------------------------------------------------------
(Updated Feb. 16, 2017, 11:24 a.m.)
Review request for Ambari, Dmitro Lisnichenko and Jayush Luniya.
Bugs: AMBARI-20024
https://issues.apache.org/jira/browse/AMBARI-20024
Repository: ambari
Description (updated)
-------
.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 878d0fa
Diff: https://reviews.apache.org/r/56710/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 56710: Relax ranger config DB consistency check
rules
Posted by Jayush Luniya <jl...@hortonworks.com>.
> On Feb. 15, 2017, 9:05 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java, line 905
> > <https://reviews.apache.org/r/56710/diff/1/?file=1634531#file1634531line905>
> >
> > We shouldn't be hardcoding service names or config types in a check like this.
> > If this is preventing the user from starting Ambari Server, then we should make this type of check be a warning as opposed to a hard error, or annotate a service or config-type with a tag to relax its validation in this check.
> >
> > Please add Jayush to the code review.
>
> Andrew Onischuk wrote:
> This a one-case scenario. I would say, adding an xml syntax to metainfo.xml to Relax on given service for given config-type would be an overkill.
Agreed for 2.5 we should just address this for RANGER in code. I dont think we can make the DB check a warning if some crucial config types are missing. In the long term we can look at a cleaner solution.
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56710/#review165756
-----------------------------------------------------------
On Feb. 16, 2017, 11:24 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56710/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2017, 11:24 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jayush Luniya.
>
>
> Bugs: AMBARI-20024
> https://issues.apache.org/jira/browse/AMBARI-20024
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 878d0fa
>
> Diff: https://reviews.apache.org/r/56710/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 56710: Relax ranger config DB consistency check
rules
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Feb. 15, 2017, 9:05 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java, line 905
> > <https://reviews.apache.org/r/56710/diff/1/?file=1634531#file1634531line905>
> >
> > We shouldn't be hardcoding service names or config types in a check like this.
> > If this is preventing the user from starting Ambari Server, then we should make this type of check be a warning as opposed to a hard error, or annotate a service or config-type with a tag to relax its validation in this check.
> >
> > Please add Jayush to the code review.
>
> Andrew Onischuk wrote:
> This a one-case scenario. I would say, adding an xml syntax to metainfo.xml to Relax on given service for given config-type would be an overkill.
>
> Jayush Luniya wrote:
> Agreed for 2.5 we should just address this for RANGER in code. I dont think we can make the DB check a warning if some crucial config types are missing. In the long term we can look at a cleaner solution.
Eventually Atlas may need the same thing. I'm ok with it for now then, but we should really try to move such definitions to the service metainfo.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56710/#review165756
-----------------------------------------------------------
On Feb. 16, 2017, 11:24 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56710/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2017, 11:24 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jayush Luniya.
>
>
> Bugs: AMBARI-20024
> https://issues.apache.org/jira/browse/AMBARI-20024
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 878d0fa
>
> Diff: https://reviews.apache.org/r/56710/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 56710: Relax ranger config DB consistency check
rules
Posted by Andrew Onischuk <ao...@hortonworks.com>.
> On Feb. 15, 2017, 9:05 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java, line 905
> > <https://reviews.apache.org/r/56710/diff/1/?file=1634531#file1634531line905>
> >
> > We shouldn't be hardcoding service names or config types in a check like this.
> > If this is preventing the user from starting Ambari Server, then we should make this type of check be a warning as opposed to a hard error, or annotate a service or config-type with a tag to relax its validation in this check.
> >
> > Please add Jayush to the code review.
This a one-case scenario. I would say, adding an xml syntax to metainfo.xml to Relax on given service for given config-type would be an overkill.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56710/#review165756
-----------------------------------------------------------
On Feb. 16, 2017, 11:24 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56710/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2017, 11:24 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jayush Luniya.
>
>
> Bugs: AMBARI-20024
> https://issues.apache.org/jira/browse/AMBARI-20024
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 878d0fa
>
> Diff: https://reviews.apache.org/r/56710/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 56710: Relax ranger config DB consistency check
rules
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56710/#review165756
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java (line 905)
<https://reviews.apache.org/r/56710/#comment237618>
We shouldn't be hardcoding service names or config types in a check like this.
If this is preventing the user from starting Ambari Server, then we should make this type of check be a warning as opposed to a hard error, or annotate a service or config-type with a tag to relax its validation in this check.
Please add Jayush to the code review.
- Alejandro Fernandez
On Feb. 15, 2017, 3:13 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56710/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 3:13 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-20024
> https://issues.apache.org/jira/browse/AMBARI-20024
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 878d0fa
>
> Diff: https://reviews.apache.org/r/56710/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>