You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/05/05 21:01:26 UTC
[GitHub] [hbase] arshadmohammad opened a new pull request #1658: HBASE-24211: [Addendum] Create table is slow in large cluster when AccessController is enabled.
arshadmohammad opened a new pull request #1658:
URL: https://github.com/apache/hbase/pull/1658
HBASE-24211: [Addendum] Create table is slow in large cluster when AccessController is enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani commented on pull request #1658: HBASE-24211: [Addendum] Create table is slow in large cluster when AccessController is enabled.
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #1658:
URL: https://github.com/apache/hbase/pull/1658#issuecomment-624544285
Good to go, please take care of the checkstyle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] arshadmohammad commented on pull request #1658: HBASE-24211: [Addendum] Create table is slow in large cluster when AccessController is enabled.
Posted by GitBox <gi...@apache.org>.
arshadmohammad commented on pull request #1658:
URL: https://github.com/apache/hbase/pull/1658#issuecomment-624585348
- To fix the checkstyle removed `@deprecated Unused` as this API is in use now and was in use earlier also.
- Corrected another problem in earlier patch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1658: HBASE-24211: [Addendum] Create table is slow in large cluster when AccessController is enabled.
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1658:
URL: https://github.com/apache/hbase/pull/1658#issuecomment-624377740
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 7m 20s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 1m 25s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 8s | branch-1 passed |
| +1 :green_heart: | compile | 1m 2s | branch-1 passed with JDK v1.8.0_252 |
| +1 :green_heart: | compile | 1m 7s | branch-1 passed with JDK v1.7.0_262 |
| +1 :green_heart: | checkstyle | 2m 13s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 8s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 57s | branch-1 passed with JDK v1.8.0_252 |
| +1 :green_heart: | javadoc | 1m 6s | branch-1 passed with JDK v1.7.0_262 |
| +0 :ok: | spotbugs | 2m 49s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 20s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 3s | the patch passed |
| +1 :green_heart: | compile | 1m 0s | the patch passed with JDK v1.8.0_252 |
| +1 :green_heart: | javac | 1m 0s | the patch passed |
| +1 :green_heart: | compile | 1m 4s | the patch passed with JDK v1.7.0_262 |
| +1 :green_heart: | javac | 1m 4s | the patch passed |
| -1 :x: | checkstyle | 0m 36s | hbase-client: The patch generated 1 new + 60 unchanged - 0 fixed = 61 total (was 60) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 2m 56s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 22s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 1m 1s | the patch passed with JDK v1.8.0_252 |
| +1 :green_heart: | javadoc | 1m 12s | the patch passed with JDK v1.7.0_262 |
| +1 :green_heart: | findbugs | 4m 29s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 41s | hbase-client in the patch passed. |
| -1 :x: | unit | 135m 49s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 1m 5s | The patch does not generate ASF License warnings. |
| | | 195m 59s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.util.TestHBaseFsck |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1658/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1658 |
| JIRA Issue | HBASE-24211 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 072dd1a7ebf7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1658/out/precommit/personality/provided.sh |
| git revision | branch-1 / e4dbfe9 |
| Default Java | 1.7.0_262 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_262 |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1658/1/artifact/out/diff-checkstyle-hbase-client.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1658/1/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1658/1/testReport/ |
| Max. process+thread count | 4350 (vs. ulimit of 10000) |
| modules | C: hbase-client hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1658/1/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1658: HBASE-24211: [Addendum] Create table is slow in large cluster when AccessController is enabled.
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1658:
URL: https://github.com/apache/hbase/pull/1658#issuecomment-624763730
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 55s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 1m 27s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 7s | branch-1 passed |
| +1 :green_heart: | compile | 1m 12s | branch-1 passed with JDK v1.8.0_252 |
| +1 :green_heart: | compile | 1m 20s | branch-1 passed with JDK v1.7.0_262 |
| +1 :green_heart: | checkstyle | 2m 42s | branch-1 passed |
| +1 :green_heart: | shadedjars | 4m 4s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 13s | branch-1 passed with JDK v1.8.0_252 |
| +1 :green_heart: | javadoc | 1m 18s | branch-1 passed with JDK v1.7.0_262 |
| +0 :ok: | spotbugs | 2m 55s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 29s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 4s | the patch passed |
| +1 :green_heart: | compile | 1m 3s | the patch passed with JDK v1.8.0_252 |
| +1 :green_heart: | javac | 1m 3s | the patch passed |
| +1 :green_heart: | compile | 1m 9s | the patch passed with JDK v1.7.0_262 |
| +1 :green_heart: | javac | 1m 9s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 21s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 3m 7s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 16s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 50s | the patch passed with JDK v1.8.0_252 |
| +1 :green_heart: | javadoc | 1m 7s | the patch passed with JDK v1.7.0_262 |
| +1 :green_heart: | findbugs | 4m 45s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 39s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 149m 20s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 52s | The patch does not generate ASF License warnings. |
| | | 206m 55s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1658/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1658 |
| JIRA Issue | HBASE-24211 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 5cdcbef42b5f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1658/out/precommit/personality/provided.sh |
| git revision | branch-1 / febf15f |
| Default Java | 1.7.0_262 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_262 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1658/3/testReport/ |
| Max. process+thread count | 4616 (vs. ulimit of 10000) |
| modules | C: hbase-client hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1658/3/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] virajjasani edited a comment on pull request #1658: HBASE-24211: [Addendum] Create table is slow in large cluster when AccessController is enabled.
Posted by GitBox <gi...@apache.org>.
virajjasani edited a comment on pull request #1658:
URL: https://github.com/apache/hbase/pull/1658#issuecomment-624544285
Good to go, please take care of the checkstyle and test failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1658: HBASE-24211: [Addendum] Create table is slow in large cluster when AccessController is enabled.
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1658:
URL: https://github.com/apache/hbase/pull/1658#issuecomment-624645448
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 7m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 1m 26s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 32s | branch-1 passed |
| +1 :green_heart: | compile | 1m 2s | branch-1 passed with JDK v1.8.0_252 |
| +1 :green_heart: | compile | 1m 7s | branch-1 passed with JDK v1.7.0_262 |
| +1 :green_heart: | checkstyle | 2m 10s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 57s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 57s | branch-1 passed with JDK v1.8.0_252 |
| +1 :green_heart: | javadoc | 1m 4s | branch-1 passed with JDK v1.7.0_262 |
| +0 :ok: | spotbugs | 2m 38s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 3s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 56s | the patch passed |
| +1 :green_heart: | compile | 1m 0s | the patch passed with JDK v1.8.0_252 |
| +1 :green_heart: | javac | 1m 0s | the patch passed |
| +1 :green_heart: | compile | 1m 10s | the patch passed with JDK v1.7.0_262 |
| +1 :green_heart: | javac | 1m 10s | the patch passed |
| -1 :x: | checkstyle | 0m 36s | hbase-client: The patch generated 1 new + 60 unchanged - 0 fixed = 61 total (was 60) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 2m 50s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 4m 54s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 52s | the patch passed with JDK v1.8.0_252 |
| +1 :green_heart: | javadoc | 1m 7s | the patch passed with JDK v1.7.0_262 |
| +1 :green_heart: | findbugs | 4m 20s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 43s | hbase-client in the patch passed. |
| +1 :green_heart: | unit | 124m 46s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 57s | The patch does not generate ASF License warnings. |
| | | 182m 29s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1658/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1658 |
| JIRA Issue | HBASE-24211 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux e086dfe59325 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1658/out/precommit/personality/provided.sh |
| git revision | branch-1 / e4dbfe9 |
| Default Java | 1.7.0_262 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_262 |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1658/2/artifact/out/diff-checkstyle-hbase-client.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1658/2/testReport/ |
| Max. process+thread count | 4025 (vs. ulimit of 10000) |
| modules | C: hbase-client hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1658/2/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org