You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/08 08:30:30 UTC

[GitHub] [maven-release] michael-o commented on a diff in pull request #154: [MRELEASE-1107] Respect line separator also on release:prepare

michael-o commented on code in PR #154:
URL: https://github.com/apache/maven-release/pull/154#discussion_r990611236


##########
maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java:
##########
@@ -455,7 +453,8 @@ private String getLineSeparatorFromPom()
     {
         char current;
         String lineSeparator = "";
-        try ( InputStream is = new FileInputStream( this.project.getFile() ) )
+        File releasePom = this.project.getFile();
+        try ( InputStream is = new FileInputStream( releasePom ) )

Review Comment:
   Why this change if you don't check for the existance? I don't see a benefit...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org