You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Aman Poonia <am...@gmail.com> on 2017/03/28 01:35:05 UTC
Review Request 57980: There is a syntax error in install script hence
ambari doesn't pick the python 2.7 if system python is not present
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57980/
-----------------------------------------------------------
Review request for Ambari.
Repository: ambari
Description
-------
This snippet of code
python_binaries=( "/usr/bin/python" "/usr/bin/python2" "/usr/bin/python2.7", "/usr/bin/python2.6" )
The comma after "/usr/bin/python2.7", causes this path to be always invalid.
Diffs
-----
ambari-agent/conf/unix/install-helper.sh 0e32d0a5d8
ambari-server/conf/unix/install-helper.sh 8def27ab53
Diff: https://reviews.apache.org/r/57980/diff/1/
Testing
-------
Tested it on my worstation. Executed the tests locally.
Thanks,
Aman Poonia
Re: Review Request 57980: There is a syntax error in install script
hence
ambari doesn't pick the python 2.7 if system python is not present
Posted by Attila Doroszlai <ad...@hortonworks.com>.
> On March 28, 2017, 8:06 p.m., Alejandro Fernandez wrote:
> > ambari-agent/conf/unix/install-helper.sh
> > Line 92 (original), 92 (patched)
> > <https://reviews.apache.org/r/57980/diff/1/?file=1677348#file1677348line92>
> >
> > This looks very unpythonic. Why isn't this a list of strings as opposed to essentially a one-tuple of a single string (that is combined)
This is a shell script, not python.
- Attila
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57980/#review170323
-----------------------------------------------------------
On March 28, 2017, 3:35 a.m., Aman Poonia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57980/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 3:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This snippet of code
> python_binaries=( "/usr/bin/python" "/usr/bin/python2" "/usr/bin/python2.7", "/usr/bin/python2.6" )
> The comma after "/usr/bin/python2.7", causes this path to be always invalid.
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 0e32d0a5d8
> ambari-server/conf/unix/install-helper.sh 8def27ab53
>
>
> Diff: https://reviews.apache.org/r/57980/diff/1/
>
>
> Testing
> -------
>
> Tested it on my worstation. Executed the tests locally.
>
>
> Thanks,
>
> Aman Poonia
>
>
Re: Review Request 57980: There is a syntax error in install script
hence
ambari doesn't pick the python 2.7 if system python is not present
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On March 28, 2017, 6:06 p.m., Alejandro Fernandez wrote:
> > ambari-agent/conf/unix/install-helper.sh
> > Line 92 (original), 92 (patched)
> > <https://reviews.apache.org/r/57980/diff/1/?file=1677348#file1677348line92>
> >
> > This looks very unpythonic. Why isn't this a list of strings as opposed to essentially a one-tuple of a single string (that is combined)
>
> Attila Doroszlai wrote:
> This is a shell script, not python.
Oops, I got confused when I read python in the name
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57980/#review170323
-----------------------------------------------------------
On March 28, 2017, 1:35 a.m., Aman Poonia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57980/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 1:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This snippet of code
> python_binaries=( "/usr/bin/python" "/usr/bin/python2" "/usr/bin/python2.7", "/usr/bin/python2.6" )
> The comma after "/usr/bin/python2.7", causes this path to be always invalid.
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 0e32d0a5d8
> ambari-server/conf/unix/install-helper.sh 8def27ab53
>
>
> Diff: https://reviews.apache.org/r/57980/diff/1/
>
>
> Testing
> -------
>
> Tested it on my worstation. Executed the tests locally.
>
>
> Thanks,
>
> Aman Poonia
>
>
Re: Review Request 57980: There is a syntax error in install script
hence
ambari doesn't pick the python 2.7 if system python is not present
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57980/#review170323
-----------------------------------------------------------
ambari-agent/conf/unix/install-helper.sh
Line 92 (original), 92 (patched)
<https://reviews.apache.org/r/57980/#comment243118>
This looks very unpythonic. Why isn't this a list of strings as opposed to essentially a one-tuple of a single string (that is combined)
- Alejandro Fernandez
On March 28, 2017, 1:35 a.m., Aman Poonia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57980/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 1:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This snippet of code
> python_binaries=( "/usr/bin/python" "/usr/bin/python2" "/usr/bin/python2.7", "/usr/bin/python2.6" )
> The comma after "/usr/bin/python2.7", causes this path to be always invalid.
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 0e32d0a5d8
> ambari-server/conf/unix/install-helper.sh 8def27ab53
>
>
> Diff: https://reviews.apache.org/r/57980/diff/1/
>
>
> Testing
> -------
>
> Tested it on my worstation. Executed the tests locally.
>
>
> Thanks,
>
> Aman Poonia
>
>
Re: Review Request 57980: There is a syntax error in install script
hence
ambari doesn't pick the python 2.7 if system python is not present
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57980/#review170331
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Doroszlai
On March 28, 2017, 3:35 a.m., Aman Poonia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57980/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 3:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This snippet of code
> python_binaries=( "/usr/bin/python" "/usr/bin/python2" "/usr/bin/python2.7", "/usr/bin/python2.6" )
> The comma after "/usr/bin/python2.7", causes this path to be always invalid.
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 0e32d0a5d8
> ambari-server/conf/unix/install-helper.sh 8def27ab53
>
>
> Diff: https://reviews.apache.org/r/57980/diff/1/
>
>
> Testing
> -------
>
> Tested it on my worstation. Executed the tests locally.
>
>
> Thanks,
>
> Aman Poonia
>
>
Re: Review Request 57980: There is a syntax error in install script
hence
ambari doesn't pick the python 2.7 if system python is not present
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57980/#review170338
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On March 28, 2017, 1:35 a.m., Aman Poonia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57980/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 1:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This snippet of code
> python_binaries=( "/usr/bin/python" "/usr/bin/python2" "/usr/bin/python2.7", "/usr/bin/python2.6" )
> The comma after "/usr/bin/python2.7", causes this path to be always invalid.
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh 0e32d0a5d8
> ambari-server/conf/unix/install-helper.sh 8def27ab53
>
>
> Diff: https://reviews.apache.org/r/57980/diff/1/
>
>
> Testing
> -------
>
> Tested it on my worstation. Executed the tests locally.
>
>
> Thanks,
>
> Aman Poonia
>
>