[jira] [Commented] (TAJO-1793) result row count unmatched for UNION ALL

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179179#comment-15179179 ] 

ASF GitHub Bot commented on TAJO-1793:
--------------------------------------

Github user jihoonson commented on the pull request:

    https://github.com/apache/tajo/pull/965#issuecomment-192067428
  
    In newly added tests, the same queries of our existing tests on union are executed, which means the queries of our union tests are executed twice for query result validation and result stat validation. I think it will be better to verify both query result and result stat together.
    
    It is simple if you get the query id of executed test query. You can get the query id from ResultSet which is actually the TajoResultSetBase. Once you get the query id, you can get TableDesc of the query result which includes the stat information. Here is an example.
    
    ```
    ResultSet res = executeQuery();
    QueryId qid = ((TajoResultSetBase)res).getQueryId();
    QueryInfo queryInfo = testingCluster.getMaster().getContext().getQueryJobManager().getFinishedQuery(qid);
    TableDesc desc = queryInfo.getResultDesc();
    System.out.println(desc.getStats().getNumRows());
    ```


> result row count unmatched for UNION ALL 
> -----------------------------------------
>
>                 Key: TAJO-1793
>                 URL: https://issues.apache.org/jira/browse/TAJO-1793
>             Project: Tajo
>          Issue Type: Bug
>          Components: QueryMaster
>    Affects Versions: 0.11.0
>         Environment: single node on Macbook
>            Reporter: Youngkyong Ko
>            Assignee: Jaehwa Jung
>            Priority: Critical
>             Fix For: 0.12.0, 0.11.2
>
>
> In UNION ALL, result record count is presented wrong. 
> default> select * from test1;
> c1
> -------------------------------
> 1
> 2
> (2 rows, 0.027 sec, 4 B selected)
> default> select * from test2;
> c1
> -------------------------------
> 2
> 3
> 4
> (3 rows, 0.011 sec, 6 B selected)
> default> select c1 from test1 union all select c1 from test2;
> Progress: 100%, response time: 0.458 sec
> c1
> -------------------------------
> 1
> 2
> 2
> 3
> 4
> (2 rows, 0.458 sec, 10 B selected)
> ==> SHOULD BE "5 rows" 
> BTW, it is OK in case of  UNION . 
> default> select c1 from test1 union  select c1 from test2;
> Progress: 100%, response time: 0.241 sec
> c1
> -------------------------------
> 2
> 1
> 3
> 4
> (4 rows, 0.241 sec, 8 B selected)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)