You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/05/12 14:50:39 UTC

[GitHub] [netbeans] n3cr0cr0w opened a new issue, #4111: JSParser doesn't yet support optional dynamic property access

n3cr0cr0w opened a new issue, #4111:
URL: https://github.com/apache/netbeans/issues/4111

   ### Apache NetBeans version
   
   Apache NetBeans latest daily build
   
   ### What happened
   
   Working on some newer javascript code I noticed that the JSParser doesn't like optional dynamic property access "Expected Ident but found ["
   
   ### How to reproduce
   
   obj?.[expr]     // optional dynamic property access
   
   ### Did this work correctly in an earlier version?
   
   No
   
   ### Operating System
   
   Windows 10 22H1
   
   ### JDK
   
   15.02+7-27
   
   ### Apache NetBeans packaging
   
   Apache NetBeans binary zip
   
   ### Anything else
   
   Every Time
   
   ### Are you willing to submit a pull request?
   
   No
   
   ### Code of Conduct
   
   Yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] n3cr0cr0w commented on issue #4111: JSParser doesn't yet support optional dynamic property access

Posted by GitBox <gi...@apache.org>.
n3cr0cr0w commented on issue #4111:
URL: https://github.com/apache/netbeans/issues/4111#issuecomment-1126515527

   Initial testing looks great!
   
   Is this going to make it into NetBeans 14 or 15?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing commented on issue #4111: JSParser doesn't yet support optional dynamic property access

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #4111:
URL: https://github.com/apache/netbeans/issues/4111#issuecomment-1126517559

   15 - 14 is about to be released.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] Chris2011 commented on issue #4111: JSParser doesn't yet support optional dynamic property access

Posted by GitBox <gi...@apache.org>.
Chris2011 commented on issue #4111:
URL: https://github.com/apache/netbeans/issues/4111#issuecomment-1125233184

   If you look into the changed files and search for "?." or nullish like for "??" it is implemented, also tests were added. So maybe there is smth more wrong. Or there must be a hint in the file, where it says "Enable latest JS features for project". Just guessing, maybe he can say smth about this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing commented on issue #4111: JSParser doesn't yet support optional dynamic property access

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #4111:
URL: https://github.com/apache/netbeans/issues/4111#issuecomment-1133112300

   I intent to merge this some time next week, if there are doubts, please raise them now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing commented on issue #4111: JSParser doesn't yet support optional dynamic property access

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #4111:
URL: https://github.com/apache/netbeans/issues/4111#issuecomment-1133548972

   No - not whether rhino or nashorn were ever the parser used by javascript support, but since a long time they are not. I don't know the heritage of graaljs, but either the team that build it and the NetBeans team were close or even two intersecting groups. It looks as if at some point the original graaljs parser was used in NetBeans to build the AST of the language, but then development in the JS area of NetBeans slowed while graaljs was further progressing and the to versions drifted apart. Today there are two versions of graaljs: The original one used in graalvm and the netbeans fork Jaroslav Tulach kindly created to get the NetBeans fork onto a usable license, which I took and added the necessary parser features for es.next. It seemed easier to evolve nb-graaljs in a compatible way than make the jump to the upstream graaljs.
   
   This is all independend of javascript execution - this only effects the parsing part.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing commented on issue #4111: JSParser doesn't yet support optional dynamic property access

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #4111:
URL: https://github.com/apache/netbeans/issues/4111#issuecomment-1126452900

   Ähm - github was quicker than I liked. The reference should have been a reference. The release of 1.1 is currently being processed by sonatype.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing closed issue #4111: JSParser doesn't yet support optional dynamic property access

Posted by GitBox <gi...@apache.org>.
matthiasblaesing closed issue #4111: JSParser doesn't yet support optional dynamic property access
URL: https://github.com/apache/netbeans/issues/4111


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] n3cr0cr0w commented on issue #4111: JSParser doesn't yet support optional dynamic property access

Posted by GitBox <gi...@apache.org>.
n3cr0cr0w commented on issue #4111:
URL: https://github.com/apache/netbeans/issues/4111#issuecomment-1125102733

   @matthiasblaesing Can you add/fix the 2020 feature optional dynamic property access to optional chaining JSParser?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing commented on issue #4111: JSParser doesn't yet support optional dynamic property access

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #4111:
URL: https://github.com/apache/netbeans/issues/4111#issuecomment-1125237376

   Actually this is valid. The presented case is not yet supported by the parser.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing commented on issue #4111: JSParser doesn't yet support optional dynamic property access

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #4111:
URL: https://github.com/apache/netbeans/issues/4111#issuecomment-1126507045

   Maven central sync is done: https://repo1.maven.org/maven2/eu/doppel-helix/netbeans/lib/graaljs-parser/1.1/graaljs-parser-1.1.jar
   
   To test in an existing installation replace `webcommon/modules/ext/graaljs-parser-1.0.jar` with the 1.1 version (the name must be kept!).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] n3cr0cr0w commented on issue #4111: JSParser doesn't yet support optional dynamic property access

Posted by GitBox <gi...@apache.org>.
n3cr0cr0w commented on issue #4111:
URL: https://github.com/apache/netbeans/issues/4111#issuecomment-1126450039

   @matthiasblaesing How can I get a copy of the 1.2-SNAPSHOT to test with?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] Chris2011 commented on issue #4111: JSParser doesn't yet support optional dynamic property access

Posted by GitBox <gi...@apache.org>.
Chris2011 commented on issue #4111:
URL: https://github.com/apache/netbeans/issues/4111#issuecomment-1125186216

   Afaik @matthiasblaesing alread did this with his PR: https://github.com/apache/netbeans/pull/3599. So it should be in latest 14 rc-* release. Can you please just try not the daily build but the RC of NetBeans 14?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] Chris2011 commented on issue #4111: JSParser doesn't yet support optional dynamic property access

Posted by GitBox <gi...@apache.org>.
Chris2011 commented on issue #4111:
URL: https://github.com/apache/netbeans/issues/4111#issuecomment-1133348002

   Just wanted to understand it, due to removing of rhino and/or nashorn, graaljs is the official JS parser, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing closed issue #4111: JSParser doesn't yet support optional dynamic property access

Posted by GitBox <gi...@apache.org>.
matthiasblaesing closed issue #4111: JSParser doesn't yet support optional dynamic property access
URL: https://github.com/apache/netbeans/issues/4111


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] n3cr0cr0w commented on issue #4111: JSParser doesn't yet support optional dynamic property access

Posted by GitBox <gi...@apache.org>.
n3cr0cr0w commented on issue #4111:
URL: https://github.com/apache/netbeans/issues/4111#issuecomment-1125229901

   Just tested with RC3, same issue as the nightly builds.
   He(@matthiasblaesing) added a lot of the new ECMA features to the JSParser, it just looks like a sub-feature to 2020 optional chaining operator was missed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists