You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/21 08:12:47 UTC
[GitHub] [incubator-nuttx] jane2226 opened a new pull request #5047: fix: regulator: set ioexpander direction in regulator gpio init.
jane2226 opened a new pull request #5047:
URL: https://github.com/apache/incubator-nuttx/pull/5047
Signed-off-by: songnannan <so...@xiaomi.com>
## Summary
fix: regulator: set ioexpander direction in regulator gpio init.
## Impact
nothing
## Testing
Test the feature on my own EVB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jane2226 commented on a change in pull request #5047: fix: regulator: set ioexpander direction in regulator gpio init.
Posted by GitBox <gi...@apache.org>.
jane2226 commented on a change in pull request #5047:
URL: https://github.com/apache/incubator-nuttx/pull/5047#discussion_r772947574
##########
File path: drivers/power/regulator_gpio.c
##########
@@ -138,6 +139,14 @@ int regulator_gpio_init(FAR struct ioexpander_dev_s *iodev,
}
priv->iodev = iodev;
+
+ ret = IOEXP_SETDIRECTION(priv->iodev, desc->enable_reg,
+ IOEXPANDER_DIRECTION_OUT);
+ if (ret < 0)
+ {
Review comment:
Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5047: fix: regulator: set ioexpander direction in regulator gpio init.
Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #5047:
URL: https://github.com/apache/incubator-nuttx/pull/5047#discussion_r772930583
##########
File path: drivers/power/regulator_gpio.c
##########
@@ -138,6 +139,14 @@ int regulator_gpio_init(FAR struct ioexpander_dev_s *iodev,
}
priv->iodev = iodev;
+
+ ret = IOEXP_SETDIRECTION(priv->iodev, desc->enable_reg,
+ IOEXPANDER_DIRECTION_OUT);
+ if (ret < 0)
+ {
Review comment:
memory leak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jane2226 commented on a change in pull request #5047: fix: regulator: set ioexpander direction in regulator gpio init.
Posted by GitBox <gi...@apache.org>.
jane2226 commented on a change in pull request #5047:
URL: https://github.com/apache/incubator-nuttx/pull/5047#discussion_r772947092
##########
File path: drivers/power/regulator_gpio.c
##########
@@ -138,6 +139,14 @@ int regulator_gpio_init(FAR struct ioexpander_dev_s *iodev,
}
priv->iodev = iodev;
+
+ ret = IOEXP_SETDIRECTION(priv->iodev, desc->enable_reg,
+ IOEXPANDER_DIRECTION_OUT);
+ if (ret < 0)
+ {
Review comment:
Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jane2226 closed pull request #5047: fix: regulator: set ioexpander direction in regulator gpio init.
Posted by GitBox <gi...@apache.org>.
jane2226 closed pull request #5047:
URL: https://github.com/apache/incubator-nuttx/pull/5047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jane2226 closed pull request #5047: fix: regulator: set ioexpander direction in regulator gpio init.
Posted by GitBox <gi...@apache.org>.
jane2226 closed pull request #5047:
URL: https://github.com/apache/incubator-nuttx/pull/5047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org