You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "josehernandezfintecheandomx (via GitHub)" <gi...@apache.org> on 2023/07/29 20:28:24 UTC
[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #3338: Add flag to Savings Charges to be recognized as accrual income
josehernandezfintecheandomx opened a new pull request, #3338:
URL: https://github.com/apache/fineract/pull/3338
## Description
In order to implement [Periodic Accrual accounting for Savings products](https://cwiki.apache.org/confluence/plugins/servlet/mobile?contentId=66852861#content/view/66852861) we have added a flag to Savings Charges to It can be recognized or not as accrual income.
The API for charges was updated to support this new parameter `recognizedAsAccrualIncome` and It will be only required for the Savings charges, the other charges for other products remain as current and the default value for this will be `false`
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
- API Charge screenshot
<img width="960" alt="Screenshot 2023-07-29 at 12 02 49" src="https://github.com/apache/fineract/assets/44206706/48c8737a-230f-448f-8405-465e6968bdd0">
- Integration Tests
<img width="2029" alt="Screenshot 2023-07-29 at 13 52 27" src="https://github.com/apache/fineract/assets/44206706/eca352dc-7265-424a-81c4-8581c6d52b79">
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] josehernandezfintecheandomx commented on pull request #3338: FINERACT-1960: Add flag to Savings Charges to be recognized as accrual income
Posted by "josehernandezfintecheandomx (via GitHub)" <gi...@apache.org>.
josehernandezfintecheandomx commented on PR #3338:
URL: https://github.com/apache/fineract/pull/3338#issuecomment-1670499510
> I dont like the idea to add `recognizedAsAccrualIncome` parameter, hence all the charges are recognized as income by default.
>
> Here the value would be by default `false` which is wrong for loan charges for example.
>
> Can you please help me to understand better this changes and the business requirement it supports?
@adamsaghy I've updated the description with the Jira ticket https://issues.apache.org/jira/browse/FINERACT-1960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on pull request #3338: FINERACT-1960: Add flag to Savings Charges to be recognized as accrual income
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #3338:
URL: https://github.com/apache/fineract/pull/3338#issuecomment-1678592093
> > I dont like the idea to add `recognizedAsAccrualIncome` parameter, hence all the charges are recognized as income by default.
> > Here the value would be by default `false` which is wrong for loan charges for example.
> > Can you please help me to understand better this changes and the business requirement it supports?
>
> @adamsaghy I've updated the description with the Jira ticket https://issues.apache.org/jira/browse/FINERACT-1960
Hi
recognizedAsAccrualIncome = false by default is still a problem for all the other cases which is not related to Savings account but Loan charge where all charges are considered as income... we shall not retrieve this value as false for them... i reckon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #3338: FINERACT-1960: Add flag to Savings Charges to be recognized as accrual income
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3338:
URL: https://github.com/apache/fineract/pull/3338#issuecomment-1720312617
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1960: Add flag to Savings Charges to be recognized as accrual income [fineract]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3338: FINERACT-1960: Add flag to Savings Charges to be recognized as accrual income
URL: https://github.com/apache/fineract/pull/3338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on pull request #3338: Add flag to Savings Charges to be recognized as accrual income
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #3338:
URL: https://github.com/apache/fineract/pull/3338#issuecomment-1660095520
@josehernandezfintecheandomx Can you please link the relevant FINERACT story for this change?
@bharathc27 Could you please review the business need after it got linked?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org