[jira] Commented: (CASSANDRA-2125) Convert to using properly nested inner-classes.

["Jonathan Ellis (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991522#comment-12991522 ] 

Jonathan Ellis commented on CASSANDRA-2125:
-------------------------------------------

I think I'm -1 on doing bulk refactoring to satisfy OCD at this point.  It's not worth the cost of making merging a bitch.

> Convert to using properly nested inner-classes.
> -----------------------------------------------
>
>                 Key: CASSANDRA-2125
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2125
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Gary Dusbabek
>            Priority: Trivial
>              Labels: nit
>             Fix For: 0.8
>
>
> We do:
> class Foo{}
> class InnerFoo{}
> in Foo.java where we should be doing:
> class Foo{
>     private /*possibly static*/ class InnerFoo{}
> }
> The semantics of the former are not well-defined per the JLS and will get messy if we ever want a class called InnerFoo.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira