You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jscheffl (via GitHub)" <gi...@apache.org> on 2025/02/09 18:34:57 UTC
[PR] Adjust pre-commit config to new provider package path structure [airflow]
jscheffl opened a new pull request, #46603:
URL: https://github.com/apache/airflow/pull/46603
Adjust some path's in pre-commit config to prevent degrading providers after move.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adjust pre-commit config to new provider package path structure [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #46603:
URL: https://github.com/apache/airflow/pull/46603#issuecomment-2646566034
Alcohol-Free merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adjust pre-commit config to new provider package path structure [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #46603:
URL: https://github.com/apache/airflow/pull/46603#issuecomment-2646554203
> > I was already working on those :) but we can have it merged first :)
>
> Let me know... how far are you? Am I adding extra work to re-base? Are you close-by? :-D
Rebaseing is fine - I will rebase mine when ready..
How far I am ? Depends how much wine with my friend we'll have tonight ;).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adjust pre-commit config to new provider package path structure [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #46603:
URL: https://github.com/apache/airflow/pull/46603#issuecomment-2646555625
> Be careful! Don't drink and root. In code this means like "Don't drink and merge"
That's it yes. I am trying to hit Ballmer's peak, let's see if it works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adjust pre-commit config to new provider package path structure [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #46603:
URL: https://github.com/apache/airflow/pull/46603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adjust pre-commit config to new provider package path structure [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #46603:
URL: https://github.com/apache/airflow/pull/46603#issuecomment-2646555166
> > > I was already working on those :) but we can have it merged first :)
> >
> >
> > Let me know... how far are you? Am I adding extra work to re-base? Are you close-by? :-D
>
> Rebaseing is fine - I will rebase mine when ready..
>
> How far I am ? Depends how much wine with my friend we'll have tonight ;).
Be careful! Don't drink and root. In code this means like "Don't drink and merge"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adjust pre-commit config to new provider package path structure [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #46603:
URL: https://github.com/apache/airflow/pull/46603#discussion_r1948222997
##########
.pre-commit-config.yaml:
##########
@@ -764,7 +761,7 @@ repos:
name: Verify usage of Airflow deprecation classes in core
entry: category=DeprecationWarning|category=PendingDeprecationWarning
files: \.py$
- exclude: ^airflow/configuration\.py$|^providers/src/airflow/providers/|^scripts/in_container/verify_providers\.py$|^(providers/)?tests/.*$|^tests_common/
+ exclude: ^airflow/configuration\.py$|^providers/.*/src/airflow/providers/|^scripts/in_container/verify_providers\.py$|^(providers/)?tests/.*$|^tests_common/
Review Comment:
Good point, I was only checking for providers source, not the tests in this PR. Adjusted the changes also for /providers/tests - OK like adjusted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adjust pre-commit config to new provider package path structure [airflow]
Posted by "insomnes (via GitHub)" <gi...@apache.org>.
insomnes commented on code in PR #46603:
URL: https://github.com/apache/airflow/pull/46603#discussion_r1948216067
##########
.pre-commit-config.yaml:
##########
@@ -764,7 +761,7 @@ repos:
name: Verify usage of Airflow deprecation classes in core
entry: category=DeprecationWarning|category=PendingDeprecationWarning
files: \.py$
- exclude: ^airflow/configuration\.py$|^providers/src/airflow/providers/|^scripts/in_container/verify_providers\.py$|^(providers/)?tests/.*$|^tests_common/
+ exclude: ^airflow/configuration\.py$|^providers/.*/src/airflow/providers/|^scripts/in_container/verify_providers\.py$|^(providers/)?tests/.*$|^tests_common/
Review Comment:
I am not an expert, but I think, the deprecation exclusion expansion from `^(providers/)?tests/.*$` which previously covered tests in providers might need some adjustment for the new structure: `providers/<name>/tests/...`.
Something like `^(providers/)?tests/.*$|^(providers/.*/tests/.*$` may work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adjust pre-commit config to new provider package path structure [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #46603:
URL: https://github.com/apache/airflow/pull/46603#discussion_r1948221628
##########
.pre-commit-config.yaml:
##########
@@ -764,7 +761,7 @@ repos:
name: Verify usage of Airflow deprecation classes in core
entry: category=DeprecationWarning|category=PendingDeprecationWarning
files: \.py$
- exclude: ^airflow/configuration\.py$|^providers/src/airflow/providers/|^scripts/in_container/verify_providers\.py$|^(providers/)?tests/.*$|^tests_common/
+ exclude: ^airflow/configuration\.py$|^providers/.*/src/airflow/providers/|^scripts/in_container/verify_providers\.py$|^(providers/)?tests/.*$|^tests_common/
Review Comment:
I have it coming in my next PR where I entirely remove `providers/tests` and `providers/src`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adjust pre-commit config to new provider package path structure [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #46603:
URL: https://github.com/apache/airflow/pull/46603#issuecomment-2646555868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adjust pre-commit config to new provider package path structure [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #46603:
URL: https://github.com/apache/airflow/pull/46603#discussion_r1948222997
##########
.pre-commit-config.yaml:
##########
@@ -764,7 +761,7 @@ repos:
name: Verify usage of Airflow deprecation classes in core
entry: category=DeprecationWarning|category=PendingDeprecationWarning
files: \.py$
- exclude: ^airflow/configuration\.py$|^providers/src/airflow/providers/|^scripts/in_container/verify_providers\.py$|^(providers/)?tests/.*$|^tests_common/
+ exclude: ^airflow/configuration\.py$|^providers/.*/src/airflow/providers/|^scripts/in_container/verify_providers\.py$|^(providers/)?tests/.*$|^tests_common/
Review Comment:
Good point, I was only checking for providers source, not the tests in this PR. Adjusted the changes also for /providers/tests - OK like adjusted? (Second commit)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adjust pre-commit config to new provider package path structure [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #46603:
URL: https://github.com/apache/airflow/pull/46603#issuecomment-2646553263
> I was already working on those :) but we can have it merged first :)
Let me know... how far are you? Am I adding extra work to re-base? Are you close-by? :-D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adjust pre-commit config to new provider package path structure [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #46603:
URL: https://github.com/apache/airflow/pull/46603#issuecomment-2646523066
I was already worked on those :) but we can have it merged first :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org