You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2008/03/16 06:02:24 UTC

[jira] Created: (JCR-1479) [PATCH] don't use the reflective form of {Collection}.toArray

[PATCH] don't use the reflective form of {Collection}.toArray
-------------------------------------------------------------

                 Key: JCR-1479
                 URL: https://issues.apache.org/jira/browse/JCR-1479
             Project: Jackrabbit
          Issue Type: Improvement
          Components: jackrabbit-core
    Affects Versions: core 1.4.1
            Reporter: Dave Brosius
            Priority: Trivial
             Fix For: core 1.4.2
         Attachments: no_reflective_toarray.patch

Passing a prototype array into {Collection}.toArray that is too small makes the toArray call expend alot of effort using reflection to do it's job. It is more performant to just pass in a correctly sized prototype. This patch does this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (JCR-1479) [PATCH] don't use the reflective form of {Collection}.toArray

Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/JCR-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Brosius updated JCR-1479:
------------------------------

    Attachment: no_reflective_toarray.patch

> [PATCH] don't use the reflective form of {Collection}.toArray
> -------------------------------------------------------------
>
>                 Key: JCR-1479
>                 URL: https://issues.apache.org/jira/browse/JCR-1479
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: core 1.4.1
>            Reporter: Dave Brosius
>            Priority: Trivial
>             Fix For: core 1.4.2
>
>         Attachments: no_reflective_toarray.patch
>
>
> Passing a prototype array into {Collection}.toArray that is too small makes the toArray call expend alot of effort using reflection to do it's job. It is more performant to just pass in a correctly sized prototype. This patch does this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (JCR-1479) [PATCH] don't use the reflective form of {Collection}.toArray

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/JCR-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting resolved JCR-1479.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5

Patch committed in revision 638027. Thanks!

> [PATCH] don't use the reflective form of {Collection}.toArray
> -------------------------------------------------------------
>
>                 Key: JCR-1479
>                 URL: https://issues.apache.org/jira/browse/JCR-1479
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Dave Brosius
>            Assignee: Jukka Zitting
>            Priority: Trivial
>             Fix For: 1.5
>
>         Attachments: no_reflective_toarray.patch
>
>
> Passing a prototype array into {Collection}.toArray that is too small makes the toArray call expend alot of effort using reflection to do it's job. It is more performant to just pass in a correctly sized prototype. This patch does this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (JCR-1479) [PATCH] don't use the reflective form of {Collection}.toArray

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/JCR-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-1479:
-------------------------------

    Affects Version/s:     (was: core 1.4.1)
        Fix Version/s:     (was: core 1.4.2)
             Assignee: Jukka Zitting

> [PATCH] don't use the reflective form of {Collection}.toArray
> -------------------------------------------------------------
>
>                 Key: JCR-1479
>                 URL: https://issues.apache.org/jira/browse/JCR-1479
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Dave Brosius
>            Assignee: Jukka Zitting
>            Priority: Trivial
>         Attachments: no_reflective_toarray.patch
>
>
> Passing a prototype array into {Collection}.toArray that is too small makes the toArray call expend alot of effort using reflection to do it's job. It is more performant to just pass in a correctly sized prototype. This patch does this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.