[GitHub] [netbeans] sdedic commented on a diff in pull request #5737: Use wait node in VSCode for long running computation of children

["sdedic (via GitHub)" <gi...@apache.org>]

sdedic commented on code in PR #5737:
URL: https://github.com/apache/netbeans/pull/5737#discussion_r1152333874


##########
java/java.lsp.server/test/unit/src/org/netbeans/modules/java/lsp/server/explorer/ProjectViewTest.java:
##########
@@ -428,6 +428,8 @@ private TreeItem findChild(TreeItem parent, String... labelPath) throws Exceptio
     }
     
     private TreeItem findChild(TreeItem parent, String childLabel) throws Exception {
+        TreeNodeRegistry reg = serverLookup.lookup(TreeNodeRegistry.class);
+        reg.findNode(parent.id).getChildren().getNodes(true);

Review Comment:
   OK, this should avoid the async computation (if implemented by Children)...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists