You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "scwhittle (via GitHub)" <gi...@apache.org> on 2025/12/16 10:00:38 UTC
[PR] Clear side input caches of dofninvoker when finishing bundle. Add microbenchmarks for map_fn with side inputs. [beam]
scwhittle opened a new pull request, #37123:
URL: https://github.com/apache/beam/pull/37123
Clearing the side-input in finish_bundle is a balance that allows refreshing the input in streaming while not affecting performance as much. However this requires the sdk state_cache to be enabled to avoid repeated lookups to the runner.
I was originally trying to optimize the code other ways but most of the overhead appears to be due to cython/Python interactions so the fast-path cache for repeated process invocations is important.
Improve the map_fn test by using common utilities.
Add support to benchmarks to add profiling.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clear side input caches of dofninvoker when finishing bundle. Add microbenchmarks for map_fn with side inputs. [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #37123:
URL: https://github.com/apache/beam/pull/37123#issuecomment-3659729686
## Summary of Changes
Hello @scwhittle, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing the performance and observability of Apache Beam pipelines, particularly concerning side input handling and microbenchmarking. It introduces a refined caching strategy for side inputs within the `DoFnInvoker` to ensure data freshness in streaming while maintaining efficiency. Concurrently, the PR expands the microbenchmark suite with new tests for `map_fn` transformations involving side inputs and integrates profiling capabilities, providing better tools for performance measurement and optimization.
### Highlights
* **Side Input Cache Management**: The `PerWindowInvoker` now explicitly clears cached side input arguments at the end of each bundle via a new `invoke_finish_bundle` method. This change allows side inputs to be refreshed in streaming pipelines without impacting performance, provided the SDK state cache is enabled.
* **Refactored Caching Logic**: The internal caching mechanism within `PerWindowInvoker` has been refactored, replacing boolean flags like `recalculate_window_args` and `has_cached_window_args` with dedicated `should_cache_args` and explicit `cached_args_for_process`/`cached_kwargs_for_process` variables for clearer state management.
* **New Microbenchmarks for map_fn with Side Inputs**: Added new microbenchmarks specifically designed to measure the performance of `map_fn` operations, including scenarios with global and fixed-windowed side inputs, and an uncached global side input scenario for comparison.
* **RuntimeValueProvider Experiment Propagation**: Ensured that `RuntimeValueProvider` correctly receives and propagates experiment flags from pipeline options in both `DirectRunner` and `FnApiRunner` contexts.
* **Profiling Support in Benchmarks**: The microbenchmark utility (`apache_beam.tools.utils`) now includes support for `cProfile`, allowing users to generate and dump profiling statistics during benchmark runs for detailed performance analysis.
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
<b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b>
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clear side input caches of dofninvoker when finishing bundle. Add microbenchmarks for map_fn with side inputs. [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37123:
URL: https://github.com/apache/beam/pull/37123#issuecomment-4466898906
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clear side input caches of dofninvoker when finishing bundle. Add microbenchmarks for map_fn with side inputs. [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #37123: Clear side input caches of dofninvoker when finishing bundle. Add microbenchmarks for map_fn with side inputs.
URL: https://github.com/apache/beam/pull/37123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clear side input caches of dofninvoker when finishing bundle. Add microbenchmarks for map_fn with side inputs. [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37123:
URL: https://github.com/apache/beam/pull/37123#issuecomment-3901853555
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clear side input caches of dofninvoker when finishing bundle. Add microbenchmarks for map_fn with side inputs. [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #37123: Clear side input caches of dofninvoker when finishing bundle. Add microbenchmarks for map_fn with side inputs.
URL: https://github.com/apache/beam/pull/37123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clear side input caches of dofninvoker when finishing bundle. Add microbenchmarks for map_fn with side inputs. [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37123:
URL: https://github.com/apache/beam/pull/37123#issuecomment-3940883973
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clear side input caches of dofninvoker when finishing bundle. Add microbenchmarks for map_fn with side inputs. [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37123:
URL: https://github.com/apache/beam/pull/37123#issuecomment-4525402831
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org