You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/02/01 03:24:06 UTC

[GitHub] [pulsar] tisonkun opened a new pull request, #19380: [cleanup] Remove legacy preview instructions

tisonkun opened a new pull request, #19380:
URL: https://github.com/apache/pulsar/pull/19380

   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on pull request #19380: [cleanup] Remove legacy preview instructions

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #19380:
URL: https://github.com/apache/pulsar/pull/19380#issuecomment-1411703267

   Hi @Anonymitaet , this PR doesn't remove the label but update the comment :)
   
   Please take a closer look on the diff.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] momo-jun merged pull request #19380: [cleanup] Remove legacy preview instructions

Posted by "momo-jun (via GitHub)" <gi...@apache.org>.
momo-jun merged PR #19380:
URL: https://github.com/apache/pulsar/pull/19380


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Anonymitaet commented on pull request #19380: [cleanup] Remove legacy preview instructions

Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet commented on PR #19380:
URL: https://github.com/apache/pulsar/pull/19380#issuecomment-1411699296

   @tisonkun thanks for your contribution! While I think we still need this label because some descriptions made to code files belong to `doc` as well.
   
   For example, sometimes engineers will update the descriptions in the [Java admin API code files](https://github.com/apache/pulsar/blob/fa6af432ef3d015b371121afd9324ba7f393994d/pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Brokers.java#L36) (left), actually, they are rendered as [Java admin API reference docs](https://pulsar.apache.org/api/admin/2.11.x/org/apache/pulsar/client/admin/Brokers.html#getActiveBrokers()) (right). In this way, the PR should be labeled with `doc`. 
   
   This is similar for:
   - Pulsar admin API Reference docs (pulsar-admin, REST API, Java admin API)
   - Pulsar client API Reference docs (Java, CPP, Python)
   
   <img width="1960" alt="image" src="https://user-images.githubusercontent.com/50226895/215996533-4c43db76-d9f6-40c4-a3b5-efc59dbb0571.png">
   
   cc @momo-jun @DaveDuggins @D-2-Ed 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Anonymitaet commented on pull request #19380: [cleanup] Remove legacy preview instructions

Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet commented on PR #19380:
URL: https://github.com/apache/pulsar/pull/19380#issuecomment-1411803666

   Oops, sorry my fault! I thought it was removed. I've approved this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org